[#12626] - com_search on back-end: Results links opens in backend window instead of new Tab
- Fixed in Code Base
- 5 Nov 2016
- Medium
- Build: staging
- Easy Test
- # 12626
- Diff
- brianteeman:search_results
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11852 .
Summary of Changes
In the list of search results the link to the search now opens in a new window
An icon is added to visually indicate that it is opening in a new window and a screen reader only text link is also present.
Testing Instructions
Enable search results in the admin search component
Perform a few searches in the front end
Return to the search component in the admin and you will see the log of the searched terms.
The number at the end of the row is the number of times that the term has been searched for.
Click on the link and it will open in a new window/tab
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Administration Components Installation Language & Strings External Library Libraries |
Do you want to hard code the english text?
No - oops
Ok I will check. That's how we do it elsewhere - nut doesn't mean it's
correct :)
| Labels | |||
| Easy | No | ⇒ | Yes |
| Labels | |||
| Category | Administration Components Installation Language & Strings External Library Libraries | ⇒ | Administration Components |
I have tested this item
1. Enabled search results in the admin search component
2. Performed a few searches in the front end
3. Returned to the search component in the admin and saw the log of the searched terms.
4. Att. The number at the end of the row is NOT the number of times that the term has been searched for (That is HITS) but the number of search result.
5. After applying the test I clicked on the link (Under results) and it indeed opened in a new window/tab on the Frontend (instead of same backend window).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12626.
I have tested this item
Link does indeed open in a new window, showing the search results.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12626.
@brianteeman can we RTC or do you want to change something here?
Its fine for merging from my perspective. The suggestion from Andre did not
work.
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12626.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-05 09:25:01 |
| Closed_By | ⇒ | rdeutz |
Thanks
Hmm look like you have mixed commits here?