Hello,

I tested this PR and get the following error message:

Warning (!): Sprintf () [<a href='function.sprintf'> function.sprintf </ a>]: Too few arguments in C: \ wamp \ www \ git-auth \ libraries \ joomla \ language \ text . php on line 246
Call Stack
# Time Memory Function Location
1 0.0003 672200 {main} () .. \ index.php: 0
2 0.0343 4741872 JApplicationWeb-> execute () .. \ index.php: 24
3 0.0343 4741872 JApplicationTracker-> doExecute () .. \ in Unknown: 247
4 0.0770 5558304 JApplicationTracker-> executeComponent () .. \ tracker.php: 255
5 0.0794 5636840 UsersControllerGhlogin-> execute () .. \ tracker.php: 330
6 1.5736 7437520 User Registration Model-> register () .. \ ghlogin.php: 83
7 1.8128 9711832 JText :: sprintf () .. \ registration.php: 469
8 1.8128 9712984 call_user_func_array () .. \ text.php: 246

(!) Fatal error: Call to undefined function curl_init () in C: \ wamp \ www \ git-auth \ components \ com_users \ controllers \ ghlogin.php on line 117
Call Stack
# Time Memory Function Location
1 0.0003 672200 {main} () .. \ index.php: 0
2 0.0343 4741872 JApplicationWeb-> execute () .. \ index.php: 24
3 0.0343 4741872 JApplicationTracker-> doExecute () .. \ in Unknown: 247
4 0.0770 5558304 JApplicationTracker-> executeComponent () .. \ tracker.php: 255
5 0.0794 5636840 UsersControllerGhlogin-> execute () .. \ tracker.php: 330
6 1.8131 9704064 UsersControllerGhlogin-> save avatar () .. \ ghlogin.php: 90

What is wrong? Thanks for your answers and I wish you a nice evening.

greeting
Tobi

OK, the warning is about missing language files (my fault)
The fatal is about cUrl not available on the server - also my fault as I missed a check.
Since this is a request I have not been able to do with JHttp - could you enable cUrl (they say it goes like this) OR just put a return true at the beginning of the function ?

Thanks for testing ;)

Hello,

after I enabled cURL, it works very well. Great work! ;)

greeting
Tobi

Does that have to be hardcoded to use curl or can we use JHttp to get whatever it was that caused the error? Or is this just the first cut and bugs are expected?

The hard coded curl is used to make a silly redirect which is made when requesting the default GitHub avatar. Maybe it also works with JHttp aka url_fopen, and I did not found the right parameters.

The PR is more about authentication - avatars are nice but not vital...

But yes, bugs are always expected :P

This could be closed now that we're using the Framework GitHub package, right?

Well, the actual code needs to be refactored a bit now that we're using the Framework code (and some of the stuff doesn't exist now), but the issue itself is still valid.

I would even raise the priority (if possible) as I think the "user/auth/acl" part should be cleared rather sooner than later so we can move on..

The question is (still) if we really need a separate user management or if we can live with the fact that every person contributing to the tracker must have an account on GitHub.

This PR does just this and also supports the first "submitting" action allowing to submit comment on issues to GitHub.

Should I refactor ?

In terms of user management, at the most, we'll need some sort of basic ACL for some of the code. Otherwise, we don't need anything complicated. One of the ideas for later on is to have user profiles, so we'll need something linking the user accounts between the app and GitHub.

We've pretty much gotten the OK from all but the "I want nothing to do with GitHub" crowd in JBS that requiring a GitHub account is a good way to go, so we're past that battle.

⇒ #103