Hmm...

if ($item->commits)
{
    $commits = json_decode($item->commits);
    $lastCommit = end($commits);
    $sha = $lastCommit->sha; // this line throws an error
}

Possible check for object could work, but why $lastCommit = end($commits); does not give an object all the time. That's interesting.

Maybe change to if (!empty($item->commits)) { //... }?

This will work, I just wonder why if ($item->commits) does not work - when not empty string is not a proper JSON string that give us an error,

Guess it would depend on whether it's actually an empty value or something
filled with white space characters which would invalidate things.

On Tuesday, March 15, 2016, Dmitry Rekun notifications@github.com wrote:

This will work, I just wonder why if ($item->commits) does not work -
when not empty string is not a proper JSON string that gives us an error,

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#758 (comment)

Then make it if (!empty($item->commits)) and lets close it for now :)

Did we finally solve it? :)

Looks like it. No new errors in the last 2 days.

Could it be that this happens on issues that haven't been updated?
A db dump would help...
Anyway... 666 - Bad Coder Error :(

No idea honestly. If it's supposed to trigger when the commits column isn't empty, then we have rows with what looks to be empty data but actually has some kind of empty character in it. I do see a few pull requests where the commits column is completely empty and a few others where the value is []. Either way I ain't got a clue but the error isn't triggering anymore.