[#757] - Add milestones filter. Close #723.
- Fixed in Code Base
- 14 Mar 2016
- Medium
- Build: master
- # 757
- Diff
- joomla:issue-723
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/travis-ci/push The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # 723.
Summary of Changes
Added milestones filter to issues filter bar and moved the filter bar to separate template.
Testing Instructions
Check that milestones filter is working correctly and other filters did not break.
You can test on my testing server.
Looks good here :)
My one suggestion would be to sort the milestones in order, otherwise looks fine.
@mbabker currently getMilestones() is ordered by milestone_number. What do you suggest?
The title if practical. One of the screens I looked at the filters were in
a "funny" order (not quite this but it felt something like 3.3.6, 2.5.28,
3.4.0, 3.5.0, 3.4.1)
On Monday, March 14, 2016, Dmitry Rekun notifications@github.com wrote:
@mbabker https://github.com/mbabker currently getMilestones()
https://github.com/joomla/jissues/blob/master/src/App/Projects/TrackerProject.php#L365
is ordered by milestone_number. What do you suggest?—
Reply to this email directly or view it on GitHub
#757 (comment).
Updated - now milestones are ordered by title ;)
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-14 17:58:52 |
| Closed_By | ⇒ | mbabker |
It still puts the open milestones before the closed ones. But honestly I'm OK with this.
We could add order by state DESC ?
Nah, it's fine how it is now.