User tests: Successful: Unsuccessful:
This is the first cut at the activity log. As suggested, I've renamed the comments table and am displaying the data in two tabs; Comments and Events.
It works now, but before merging, I need to finish the implementation (I didn't add it to the hooks yet) and the sample data file needs to be (finally) updated.
An idea: What if we follow some naming conventions and build the table names using the component (com_tracker) and a plural form ?
I mean instead of #__activity
this would be #__tracker_activities
Numerous advantages...
Just an idea ;)
Just a note wouldn't it be better keep the comments table?
This will save us (replace with a query) this foreach:
// Separate the event types into different area pieces
foreach ($items as $item)
{
switch ($item->event)
{
case 'comment' :
$activities['comments'][] = $item;
break;
default :
$activities['events'][] = $item;
break;
}
}
Also it isn't better for comments synchronization?
No argument from me. Feel free to update the branch; it's on the main repo.
On Monday, January 7, 2013, Nikolai Plath wrote:
An idea: What if we follow some naming conventions and build the table
names using the component (com_tracker) and a plural form ?I mean instead of #__activity this would be #__tracker_activities
Numerous advantages...
Just an idea ;)
—
Reply to this email directly or view it on GitHubhttps://github.com/JTracker/jissues/pull/66#issuecomment-11977039.
Please pardon any errors, this message was sent from my iPhone.
Look s great!
I'm merging this now, because it not only looks very nice but also deserves further attention ;)
That said, what do you think if we make, instead of the two tabs for "Comments" and "Events" one single "stream" that contains them both according to their datetime ?
This should also contain changes to the status or any other field that we have, including the "old value" and the "new value".
I mean: Display the information currently "hidden" in a tab in jcode mixed with the comments - like on GitHub..
I've updated the sample data and added the logging to the commit hooks. Should be 100% ready to go now.