avatar Hils
Hils
17 Nov 2014

View any PR, issue or comment created with issues.joomla.org/tracker

"This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/0000." <<< this wording is at the bottom of all the ones created using the tracker.

I think the wording was changed a while back to make it less prominent and it is in italic. But it might be even better if a smaller font than the actual comment could be used.

Thanks for considering this
Hils

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar Hils Hils - open - 17 Nov 2014
avatar mbabker
mbabker - comment - 17 Nov 2014

Looking at https://github.com/github/markup/tree/master#html-sanitization we may be able to do it wrapping everything in a <sub> element (like this) but that'd be the only way; the allowed options for styling are somewhat limited.

avatar Hils
Hils - comment - 17 Nov 2014

That would look much better and it could be argued that it is also semantically correct. (Is a <span> out of the question? or a new class?)

This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/560.

avatar Hils
Hils - comment - 17 Nov 2014

Is a span out of the << missing word from previous post

This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/560.

avatar mbabker
mbabker - comment - 17 Nov 2014

Class isn't a whitelisted attribute (and even if it were, it'd have to be something in GitHub's existing CSS as there's no way to import anything, nor do they allow inline styling beyond what can be accomplished with their allowed HTML tags).

avatar Hils
Hils - comment - 17 Nov 2014

Thanks again Michael, sub would be a great improvement!

avatar Hutchy68
Hutchy68 - comment - 17 Nov 2014

Can't the output be wrapped in a span tag?

$comment .= sprintf(
            '<span class="comment">This comment was created with the <a href="%1$s">%2$s Application</a> at <a href="%3$s">%4$s</a>.</span>',
            'https://github.com/joomla/jissues', 'J!Tracker',
            $application->get('uri')->base->full . 'tracker/' . $project->alias . '/' . $issue_number,
            str_replace(['http://', 'https://'], '', $application->get('uri')->base->full) . $project->alias . '/' . $issue_number
        );

Then add some crazy stuff, like font-size, background color, etc. :smile: to the template.css You can even give the <br/> tags the boot.

span.comment {
font-size: .875em;
font-style: italic;
display: block;
margin: 1em 0 0;
background: #eefeee;
padding: .25em;
}



This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/560.

avatar Hutchy68
Hutchy68 - comment - 17 Nov 2014

screen shot 2014-11-17 at 08 40 57

Not sure where my original screenshot went. :astonished:

This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/560.

avatar mbabker
mbabker - comment - 17 Nov 2014

That takes care of our app (and actually that does look pretty good). Still have to deal with its appearance on GitHub then.

avatar Hutchy68
Hutchy68 - comment - 17 Nov 2014

I see what you mean, I just fixed my comment via GitHub issues.

How about a <hr/> element

Then you eliminate the need for a margin in comment class. Add <hr/> but css the border-top to none for the app. You would have to add a margin-bottom:none for <hr>.



This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/560.

avatar Hils
Hils - comment - 17 Nov 2014

Watching & appreciating you two solving this! thank you :)

avatar Hutchy68
Hutchy68 - comment - 17 Nov 2014

Even though it says at the bottom, I really created this in GitHub Issue interface.

Update by editing. I added the <span> tags. Are they being stripped out by the app? They aren't showing on the tracker.


This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/560.
avatar mbabker
mbabker - comment - 17 Nov 2014

Nothing should be getting stripped, all the comments are being parsed through GitHub's Markdown Parser API. Might be in the comments as raw HTML but not being displayed.

avatar Hils
Hils - comment - 17 Nov 2014

the link you are adjusting actually goes to the wrong page - it goes to the CMS tracker and not the Issues tracker:
http://issues.joomla.org/tracker/jtracker/560

avatar Hutchy68
Hutchy68 - comment - 17 Nov 2014

I just deleted it, but I found a bug inadvertently.

screen shot 2014-11-17 at 09 43 16

This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/560.

avatar Hutchy68
Hutchy68 - comment - 17 Nov 2014

Yeah, it should be http://issues.joomla.org/tracker/jtracker/#. It's missing the /tracker in the URL.

avatar Hils
Hils - comment - 17 Nov 2014

You fixed it - thank you!

avatar b2z
b2z - comment - 19 Nov 2014

So what's the final decision? :)

This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/560.

avatar b2z
b2z - comment - 2 Dec 2014

Can someone tell me what is the solution to implement? Thank you ;)

avatar elkuku
elkuku - comment - 3 Dec 2014

I just tested with <hr /> and <sub> and it looks like this: jtester/tests#15 (comment)

How does that look?

avatar b2z
b2z - comment - 12 Dec 2014

@elkuku for me it looks nice.

avatar elkuku elkuku - close - 12 Dec 2014
avatar elkuku elkuku - close - 12 Dec 2014
avatar elkuku elkuku - change - 12 Dec 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-12-12 14:02:25
avatar elkuku
elkuku - comment - 12 Dec 2014

OK, done - THANKS all :wink:

Add a Comment

Login with GitHub to post a comment