View any PR, issue or comment created with issues.joomla.org/tracker
"This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/0000." <<< this wording is at the bottom of all the ones created using the tracker.
I think the wording was changed a while back to make it less prominent and it is in italic. But it might be even better if a smaller font than the actual comment could be used.
Thanks for considering this
Hils
That would look much better and it could be argued that it is also semantically correct. (Is a <span>
out of the question? or a new class?)
This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/560.
Is a span out of the << missing word from previous post
This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/560.
Class isn't a whitelisted attribute (and even if it were, it'd have to be something in GitHub's existing CSS as there's no way to import anything, nor do they allow inline styling beyond what can be accomplished with their allowed HTML tags).
Thanks again Michael, sub would be a great improvement!
Can't the output be wrapped in a span tag?
$comment .= sprintf(
'<span class="comment">This comment was created with the <a href="%1$s">%2$s Application</a> at <a href="%3$s">%4$s</a>.</span>',
'https://github.com/joomla/jissues', 'J!Tracker',
$application->get('uri')->base->full . 'tracker/' . $project->alias . '/' . $issue_number,
str_replace(['http://', 'https://'], '', $application->get('uri')->base->full) . $project->alias . '/' . $issue_number
);
Then add some crazy stuff, like font-size, background color, etc. to the template.css You can even give the <br/>
tags the boot.
span.comment {
font-size: .875em;
font-style: italic;
display: block;
margin: 1em 0 0;
background: #eefeee;
padding: .25em;
}
This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/560.
Not sure where my original screenshot went.
This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/560.
That takes care of our app (and actually that does look pretty good). Still have to deal with its appearance on GitHub then.
I see what you mean, I just fixed my comment via GitHub issues.
How about a <hr/>
element
Then you eliminate the need for a margin in comment class. Add <hr/>
but css the border-top to none for the app. You would have to add a margin-bottom:none
for <hr>
.
This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/560.
Watching & appreciating you two solving this! thank you :)
Even though it says at the bottom, I really created this in GitHub Issue interface.
Update by editing. I added the <span>
tags. Are they being stripped out by the app? They aren't showing on the tracker.
Nothing should be getting stripped, all the comments are being parsed through GitHub's Markdown Parser API. Might be in the comments as raw HTML but not being displayed.
the link you are adjusting actually goes to the wrong page - it goes to the CMS tracker and not the Issues tracker:
http://issues.joomla.org/tracker/jtracker/560
I just deleted it, but I found a bug inadvertently.
This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/560.
Yeah, it should be http://issues.joomla.org/tracker/jtracker/#
. It's missing the /tracker
in the URL.
You fixed it - thank you!
So what's the final decision? :)
This comment was created with the J!Tracker Application at issues.joomla.org/jtracker/560.
Can someone tell me what is the solution to implement? Thank you ;)
I just tested with <hr />
and <sub>
and it looks like this: jtester/tests#15 (comment)
How does that look?
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-12 14:02:25 |
OK, done - THANKS all
Looking at https://github.com/github/markup/tree/master#html-sanitization we may be able to do it wrapping everything in a
<sub>
element (like this) but that'd be the only way; the allowed options for styling are somewhat limited.