Is the differences button available to everyone or just some users?
If it is for everyone then there is a potential security issue. A user could enter confidential information here such as their site login details and we can never remove it as it will always be accessible by clicking on differences
If the differences button is only for users with elevated privileges then its not an issue
Yes you only need "view" permissions to see those differences.
I think we can add a "delete event" functionality (we still need to implement that for comments I guess)
The last option would be to "hack" the database and manually delete the offending row...
Do we need the differences button?
I'm very concerned about this as its very common for users to post usernames and passwords
Do we want to track changes to the title or description text?
Personally I don't see the need to track any changes. What is the use case?
On 11 Sep 2014 04:18, "Nikolai Plath" notifications@github.com wrote:
Do we want to track changes to the title or description text?
—
Reply to this email directly or view it on GitHub
#485 (comment).
Some of it serves as an audit log of sorts. Some of it is data that was
tracked in JoomlaCode. We weren't tracking the issue descriptions though.
On Thursday, September 11, 2014, Brian Teeman notifications@github.com
wrote:
Personally I don't see the need to track any changes. What is the use
case?
On 11 Sep 2014 04:18, "Nikolai Plath" > wrote:Do we want to track changes to the title or description text?
—
Reply to this email directly or view it on GitHub
#485 (comment).—
Reply to this email directly or view it on GitHub
#485 (comment).
The easiest option then (without seeing the code) is not to track the
descriptions or comments.
On 11 September 2014 06:51, Michael Babker notifications@github.com wrote:
Some of it serves as an audit log of sorts. Some of it is data that was
tracked in JoomlaCode. We weren't tracking the issue descriptions though.On Thursday, September 11, 2014, Brian Teeman notifications@github.com
wrote:Personally I don't see the need to track any changes. What is the use
case?
On 11 Sep 2014 04:18, "Nikolai Plath" > wrote:Do we want to track changes to the title or description text?
—
Reply to this email directly or view it on GitHub
#485 (comment).—
Reply to this email directly or view it on GitHub
#485 (comment).—
Reply to this email directly or view it on GitHub
#485 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
| Labels |
Added:
enhancement
|
||
Now the difference will be tracked, but not displayed. If you feel that we need to change the behavior open this issue again ;)
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-02 12:35:52 |
It is for everyone...