GitHub sync bug
avatar brianteeman
brianteeman
30 Aug 2014

Steps to reproduce the issue

Open 416 and change its state from closed to open and save

Expected result

the status would correctly change

Actual result

Validation Failed
screen shot 2014-08-30 at 17 44 51

avatar brianteeman brianteeman - open - 30 Aug 2014
avatar elkuku
elkuku - comment - 31 Aug 2014

I just tried it without any problem: http://issues.joomla.org/tracker/jtracker/416#event-32047

Not sure what is going wrong here :(

avatar b2z b2z - change - 31 Aug 2014
Labels Added: GitHub sync
avatar b2z
b2z - comment - 31 Aug 2014

May be some kind of temp error or something. Let's wait and see will it happen again or not.

avatar brianteeman
brianteeman - comment - 31 Aug 2014

Just tried again. I see debug is on right now so the full stack error I get is

screen shot 2014-08-31 at 04 10 56

Is it permissions?

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar b2z
b2z - comment - 31 Aug 2014

Hmm... GitHub API says that it something wrong with the fields.

Sending invalid fields will result in a 422 Unprocessable Entity response.

Strange... I've added my test user bzz0 to editors group of JTracker project (it is the same as you are in) and tried to change the status of issue 416. No errors :confused:

avatar brianteeman
brianteeman - comment - 31 Aug 2014

I am just a user not a developer ;) I am just reporting what I see

On 31 August 2014 10:31, Dmitry Rekun notifications@github.com wrote:

Hmm... GitHub API says https://developer.github.com/v3/#client-errors
that it something wrong with the fields.

Sending invalid fields will result in a 422 Unprocessable Entity response.

Strange... I've added my test user bzz0 to editors group of JTracker
project (it is the same as you are in) and tried to change the status of
issue 416. No errors [image: :confused:]


Reply to this email directly or view it on GitHub
#458 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 31 Aug 2014

Maybe its a permissions on github not on Jtracker?

On 31 August 2014 10:32, Brian Teeman brian@teeman.net wrote:

I am just a user not a developer ;) I am just reporting what I see

On 31 August 2014 10:31, Dmitry Rekun notifications@github.com wrote:

Hmm... GitHub API says https://developer.github.com/v3/#client-errors
that it something wrong with the fields.

Sending invalid fields will result in a 422 Unprocessable Entity response.

Strange... I've added my test user bzz0 to editors group of JTracker
project (it is the same as you are in) and tried to change the status of
issue 416. No errors [image: :confused:]


Reply to this email directly or view it on GitHub
#458 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar elkuku elkuku - reference | - 31 Aug 14
avatar elkuku elkuku - change - 31 Aug 2014
Labels Added: bug
avatar b2z b2z - reference | - 2 Sep 14
avatar b2z
b2z - comment - 2 Sep 2014

@mbabker please note here when you will deploy then we will ask Brian to repeat.

avatar mbabker
mbabker - comment - 2 Sep 2014

Deployed

avatar brianteeman
brianteeman - comment - 2 Sep 2014

Just tried to reopen a closed issue and got this beautiful error

array(7) { ["exception"]=> string(21) "422 Validation Failed" ["user"]=>
string(6) "joomla" ["project"]=> string(7) "jissues" ["issueNo"]=>
string(3) "467" ["state"]=> string(4) "open" ["old_state"]=> string(6)
"closed" ["data"]=> array(10) { ["status"]=> string(1) "1" ["priority"]=>
string(1) "3" ["rel_type"]=> string(0) "" ["rel_number"]=> string(0) ""
["build"]=> string(1) "." ["easy"]=> string(1) "0" ["title"]=> string(12)
"Issue Status" ["description_raw"]=> string(367) "It appears we have two
different status selections. One is used in advanced search and one is used
on an issue. Can we just have one please screen shot 2014-09-02 at 04 02<br>
25
screen shot 2014-09-02 at 04 02 31"
["id"]=> string(4) "4680" ["issue_number"]=> string(3) "467" } }
Unrecoverable GitHub error - sry ;(

On 2 September 2014 12:58, Michael Babker notifications@github.com wrote:

Deployed


Reply to this email directly or view it on GitHub
#458 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar zero-24
zero-24 - comment - 2 Sep 2014

@brianteeman here it works ok for me (i'm also "only" a JBS member): http://issues.joomla.org/tracker/joomla-cms/4204

Just tried to reopen a closed issue and got this beautiful error

Do you test it by changeing the status dropdown (closed --> open --> save --> closed --> save?) or have you a other way?

avatar brianteeman
brianteeman - comment - 2 Sep 2014

I cn confirm tht it works on on the CMS tracker - it appears to be just on this J!tracker (permissions??)

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar mbabker
mbabker - comment - 2 Sep 2014

Shouldn't be an issue with GitHub; the projects both have the issue bot
configured to it and the bot has access on the repo. Weird.

On Tue, Sep 2, 2014 at 12:30 PM, Brian Teeman notifications@github.com
wrote:

I cn confirm tht it works on on the CMS tracker - it appears to be just on
this J!tracker (permissions??)

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
http://issues.joomla.org/http://issues.joomla.org/
http://issues.joomla.org/.


Reply to this email directly or view it on GitHub
#458 (comment).

avatar brianteeman
brianteeman - comment - 2 Sep 2014

Was just an idea

On 2 September 2014 17:33, Michael Babker notifications@github.com wrote:

Shouldn't be an issue with GitHub; the projects both have the issue bot
configured to it and the bot has access on the repo. Weird.

On Tue, Sep 2, 2014 at 12:30 PM, Brian Teeman notifications@github.com
wrote:

I cn confirm tht it works on on the CMS tracker - it appears to be just
on
this J!tracker (permissions??)

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
http://issues.joomla.org/http://issues.joomla.org/
http://issues.joomla.org/.


Reply to this email directly or view it on GitHub
#458 (comment).


Reply to this email directly or view it on GitHub
#458 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar mbabker
mbabker - comment - 2 Sep 2014

Not a bad one, I did double check everything but don't see an apparent issue with the GitHub connection.

avatar b2z
b2z - comment - 3 Sep 2014

Should we add errors here to get them from GitHub? Like this may be:

$message = isset($error->message) ? $error->message . ' ' . $error->errors : 'Invalid response received from GitHub.';
avatar b2z
b2z - comment - 25 Sep 2014

@brianteeman is it still present?

avatar brianteeman
brianteeman - comment - 25 Sep 2014

Its fine now. I've changed lots of status since this and it hasnt happened again

avatar brianteeman brianteeman - close - 25 Sep 2014
avatar brianteeman brianteeman - close - 25 Sep 2014
avatar brianteeman brianteeman - change - 25 Sep 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-09-25 08:40:37

Add a Comment

Login with GitHub to post a comment