Maybe we can still have our colors if we do a

data-content="<span class='label' style='background-color: #{{ category.color }};'>&nbsp;&nbsp;</span> {{ category.title }}"

Exactly, like on GH.

Should be better than 'ugly'

By the way, I'm not so sure about this, because I didn't write the style thing, as you can see it's the same with GitHub's displaying color, as I just copied it's style attributes.
Is this OK or we can't do that?

Oh just went through GitHub's terms of service

The look and feel of the Service is copyright ©2010 GitHub Inc. All rights reserved. You may not duplicate, copy, or reuse any portion of the HTML/CSS, Javascript, or visual design elements or concepts without express written permission from GitHub.

Sad it's not open source itself.

Reverted the change.

data-content="<span class='label' style='background-color: #{{ category.color }};'>&nbsp;&nbsp;</span> {{ category.title }}"

Does not look so good. So is there a better way than this? Not familiar with the CSS stuff...

Wow! That's really sad :(

I thought it would be an open source software as it's hosting so many FOSS on it.
Sadly it's not ;( And we have to come up with our way of displaying color, otherwise we have to abandon the color stuff. But to be honest, I like displaying color...

Sorry I'm not getting it.. The screen shot you posted looked really good.

I don't think that we will get into any license trouble with this code, especially with GitHub

The style attribute of the srceenshot is the same as GitHub as I just simply copied from its CSS file. 

I thought GitHub should be open source and we are okay to just copy its design. But the terms of service says another thing...
—
Sent from Mailbox

On Fri, Aug 29, 2014 at 12:45 AM, Nikolai Plath notifications@github.com
wrote:

Sorry I'm not getting it.. The screen shot you posted looked really good.

I don't think that we will get into any license trouble with this code, especially with GitHub

Reply to this email directly or view it on GitHub:
#457 (comment)

Ah well, just leave off the CSS stuff then - labels already have rounded corners in Bootstrap, let those UI experts do the "fine tuning" IF they agree that this one is less ugly ³

But to be on the safe side, you would have to somehow "hard revert" this 4d401df commit, because the code already "exists" - but I'm not a license expert either...

Does not look so good.

It looks like this without any CSS changes - ugly?

It looks like this without any CSS changes - ugly?

ok ;)

@elkuku On my laptop the square looks more like a triangle like this:

And BTW, how to hard revert the commits?
I went through this, but I think it's how to remove a file?
If I rebase and delete this branch, will the commit still be there?

Found a solution here, and will do it later.
http://blog.stevenocchipinti.com/2014/03/10/completely-removing-a-git-commit-due-to-sensitive-information/
It's like I've done something illegal and trying to do some dangerous stuff to cover it up..

I am sure one of our CSS gurus will find some nifty lines to make it look a perfect square - to me it's "not that bad" :D

how to hard revert the commits?

You could simply open a new PR from master and apply the diff from here - no problem ;)

I am sure one of our CSS gurus will find some nifty lines to make it look a perfect square - to me it's "not that bad" :D

Yeap, so @allenzhao do not bother so much ;)

@allenzhao will you make a new PR?

Sure, maybe later today.

Cheers | 顺颂时祺
Allen Zhao | 赵泽涵

在 2014年8月31日，14:48，Dmitry Rekun notifications@github.com 写道：

@allenzhao will you make a new PR?

—
Reply to this email directly or view it on GitHub.