bug
avatar zero-24
zero-24
5 Aug 2014

Steps to reproduce the issue

Please see here:
http://issues.joomla.org/tracker/joomla-cms/4069

@brianteeman add a Label on github (don't login into JTracker) and also change the staus form RTC back to open.

Same thing is that the description was changed any how.

Expected result

Adding a label on github don't change the description and status on JTracker

Actual result

Adding a label on github change the description and status on JTracker. See: http://issues.joomla.org/tracker/joomla-cms/4069

avatar zero-24 zero-24 - open - 5 Aug 2014
avatar zero-24 zero-24 - change - 5 Aug 2014
Title
Chaging Label on Github change status on JTracker
Changing Label on Github change status on JTracker
avatar mbabker
mbabker - comment - 5 Aug 2014

I think I get where you're going with this, and if I didn't fully understand feel free to yell :-D

There are some events that the GitHub API doesn't trigger a webhook request that JTracker can process on. So we have a cron job running hourly on each the CMS and JTracker repos to do some of those tasks. Right now the cron runs every half hour and alternates between repos so we aren't pushing too many API requests at once. We might be able to bump that to every half hour for each repo to keep things more in sync.

avatar zero-24
zero-24 - comment - 5 Aug 2014

I think I get where you're going with this, and if I didn't fully understand feel free to yell :-D

IIRC the "Status" column on JTracker is "local" and has nothing todo with the github label: RTC, Has/Needs JC, etc.

After my test on the Itm: http://issues.joomla.org/tracker/joomla-cms/4069 I have change the "local" status from open to Pending and after the second test to RTC (Also the easy test option). But after Brian change the label (on github) he also change the "local" status from RTC / Pending back to Open. (possible this was done by the cronjob)

I hope it is more clearly now :-D

avatar mbabker
mbabker - comment - 5 Aug 2014

Oh, OK!

Ya, we don't quite have the code set up to change statuses based on things like labels or if it's a PR just yet (PRs should theoretically default to Pending anyway).

avatar zero-24
zero-24 - comment - 5 Aug 2014

(PRs should theoretically default to Pending anyway).

Yea i already open a issue see here: #402

The issue here is if i understand it correct that the status on github is only open or closed. On the cronjob sync the status is synced and if it is open (on github) it overwrite our value (e.g. RTC, Pending, ...) back to open.
Likewise with the "Easy test" option. (nothing on github --> moving back to the default)

How can i find the cronjob/sync code? Maybe i can find the issue

avatar elkuku
elkuku - comment - 5 Aug 2014

I believe we have a bug here...
I think the line that causes trouble is this: https://github.com/joomla/jissues/blob/master/cli/Application/Command/Get/Project/Issues.php#L264
where we only set the status value to either open or closed, so any other value previously set (pending, rtc, etc) would be lost.
I think we need some brainstorming to properly fix thix.

The easy value however should not be changed by the cron job.

The "set the status to pending if the issue is a pull request" is a very Joomla! CMS issue tracker specific thing that should be implemented on a project level - suggestions welcome :wink:

avatar elkuku elkuku - change - 5 Aug 2014
Labels Added: bug
avatar zero-24
zero-24 - comment - 5 Aug 2014

@mbabker and @elkuku please see here: #408

avatar mbabker
mbabker - comment - 5 Aug 2014

@elkuku - Trying to avoid project specific behaviors is why I went with an event system in the hook controllers. That may be one way around it.

avatar b2z
b2z - comment - 12 Aug 2014

Closed via #411

avatar b2z b2z - change - 12 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-12 06:33:52
avatar b2z b2z - close - 12 Aug 2014

Add a Comment

Login with GitHub to post a comment