[#406] - Decouple Issues Table from the User object
- Closed
- 4 Aug 2014
- Medium
- Build: master
- # 406
- Diff
- joomla:modified-by
- Success continuous-integration/travis-ci The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR will decouple Issues Table form the User object. We needed it to create modified_by value. Now this value is passed from the Controller.
I also added modified_date for new items as this is the same behavior as creating issues from GitHub.
BTW when we change issue title on GitHub it is not changing on Tracker. Is it expected behavior?
Just noticed that it is changed, but with the delay. Sync ;)
You may blame the J!Tracker Application for transmitting this comment.
IIRC there isn't an event hook on updates anymore so it depends on our cron jobs to make corrections.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-04 23:33:22 |
I think the modified_date and modified_by values will be set from GitHub as the modified_date is also important for syncing, so setting them here might not be required (or useful - IDK...)
The decoupling makes perfect sense.
I think the modified_date and modified_by values will be set from GitHub as the modified_date is also important for syncing
Yeah I know that. When you create an issue on GitHub it's automatically synced and modified_date and modified_by values are set. But if you create an issue on JTracker these are not set. That's why I decided to set them for consistency.
BTW when we change issue title on GitHub it is not changing on Tracker. Is it expected behavior?