enhancement v1.0 Success

User tests: Successful: Unsuccessful:

avatar b2z
b2z
19 Oct 2013

The first part of #48. Next part will be server side validation.

avatar b2z b2z - open - 19 Oct 2013
avatar b2z b2z - open - 19 Oct 2013
avatar mbabker
mbabker - comment - 19 Oct 2013

At a glance it's looking good. I'll pull it down shortly and test it.

avatar elkuku
elkuku - comment - 19 Oct 2013

So we're going with ini files and keys....

avatar mbabker
mbabker - comment - 19 Oct 2013

Until #124 is merged, yes, since that's what's already in place.

avatar elkuku
elkuku - comment - 19 Oct 2013

Looks like duplicated work to me if we still consider merging #124...

Look here for example.. or here....

avatar mbabker
mbabker - comment - 19 Oct 2013

I've got no issue merging #124. So do we want to do it now or wait? I've still got to write my JWC session for this here project, so I'd rather larger changes like that get merged before I've written any slides... LOL

avatar elkuku
elkuku - comment - 19 Oct 2013

We could include a language switcher with flags - that would look nice on a slide, don't you think ? ;)

avatar mbabker
mbabker - comment - 19 Oct 2013

Totally!

avatar elkuku
elkuku - comment - 19 Oct 2013

Oh, but hey... a BIG :+1: for starting with client side validation @b2z :wink:

avatar b2z
b2z - comment - 19 Oct 2013

Well I did not know that we have decided to drop usage of ini :( #124 is the final decision? What is the right way of language string usage?

Nevermind I found it :)

// template.twig
<label>
    My String

    // change to:
    {{ translate("My String") }}

    // **OR** just use a pipe and a shortcut:
    {{ "My String"|_ }}
</label>
avatar elkuku
elkuku - comment - 19 Oct 2013

I don't think there is a "right" way...
The proposal of #124 is (also) making translations "lazy", so you don't need those COM_FOO_KEY's any more.. unless you want them (maybe for long descriptions) ;)

avatar mbabker
mbabker - comment - 19 Oct 2013

That's the cool thing about this project. The right way is what we decide. We aren't stuck in the confines of another application's structure or required to use the tools of a single entity, we can implement what we want and how we want, and if something on the market doesn't suit our needs, we can just as easily write it ourselves.

avatar elkuku
elkuku - comment - 19 Oct 2013

Amen :)

avatar elkuku
elkuku - comment - 19 Oct 2013

Nevermind I found it :)

Oh that's what you meant by "right" :)

avatar elkuku
elkuku - comment - 19 Oct 2013

Yeah, and speaking of which - (not which is "right"..) maybe you can find some 5min to test this - it might save you some 10min when working with language files ;)

avatar elkuku
elkuku - comment - 19 Oct 2013

So, on topic (apologies for previous OT..) while checking out this branch I noticed that I also get this beautiful error about the wrong Http object.. (see) - should I lower my error_reporting ? :(

avatar mbabker
mbabker - comment - 19 Oct 2013

He needs to sync up the branch, your PR to fix that is merged.

avatar elkuku
elkuku - comment - 19 Oct 2013

Yeah, that's why I was wondering if I am the only one....

@test works as expected.
Not tested with a non-english language ;)

avatar mbabker
mbabker - comment - 19 Oct 2013

Not too shabby :+1:

avatar mbabker mbabker - reference | 104b6fe - 19 Oct 13
avatar mbabker mbabker - merge - 19 Oct 2013
avatar mbabker mbabker - close - 19 Oct 2013
avatar - close - 19 Oct 2013
avatar elkuku elkuku - head_ref_deleted - 3 Nov 2013

Add a Comment

Login with GitHub to post a comment