Joomla! Issue Tracker - J!Tracker

Download
Launch
Feeling Lucky

[#156] - Fix wrong Http object used for JGitHub service provider

bug Success

User tests: Successful: Unsuccessful:

avatar elkuku
elkuku
19 Oct 2013

It seems that the wrong Http object is used in the service provider:

Argument 2 passed to Joomla\Github\Github::__construct() must be an instance of 
Joomla\Github\Http, instance of Joomla\Http\Http given

Just to be sure that it's not a local Linux thingy or something... here is a PR ?

avatar elkuku elkuku - open - 19 Oct 2013
avatar elkuku elkuku - open - 19 Oct 2013
avatar mbabker
mbabker - comment - 19 Oct 2013

Yep. Why we even have a GitHub HTTP class at this point puzzles me, but might as well get it right.

avatar mbabker mbabker - reference | 0eb90df - 19 Oct 13
avatar mbabker mbabker - merge - 19 Oct 2013
avatar - close - 19 Oct 2013
avatar mbabker mbabker - close - 19 Oct 2013
avatar elkuku elkuku - head_ref_deleted - 19 Oct 2013

Add a Comment

Login with GitHub to post a comment