enhancement Pending

User tests: Successful: Unsuccessful:

avatar elkuku
elkuku
11 Oct 2012

This will "fix" the pagination, but in a javascript only way (luckily jquery).

Maybe we can also get an AJAX pagination :)

avatar elkuku elkuku - open - 11 Oct 2012
avatar elkuku elkuku - open - 11 Oct 2012
avatar drmmr763
drmmr763 - comment - 11 Oct 2012

That means that pagination will only work with JS enabled won't it? Not sure if that matters or not.

avatar elkuku
elkuku - comment - 11 Oct 2012

Yes that's true. Note that the selectors we currently have for filtering and list limit also require javascript enabled to actually reload the form.

Oh, and of course those cute icomoon icons ;)

avatar mbabker
mbabker - comment - 11 Oct 2012

Looking at this after Chad's original bug report has made me realize we're missing some stuff in our application layer dealing with the session handling (I'm not seeing sessions for site users at all right now). I'll keep this on standby, but considering the pagination code (both presentation and library) is a straight copy from the CMS, it should be working. Unless it isn't working there (this is the point where I'm supposed to lie and talk about how much time I've spent playing around on the front end...).

avatar mbabker
mbabker - comment - 11 Oct 2012

As I thought, it was the lack of a session that was the root cause of the original issue. d2b40ad fixed it. Maybe this can still be usable in some form though?

avatar elkuku
elkuku - comment - 13 Oct 2012

Yes I confirm that it is "somewhat" fixed now.

The filter values get lost when paginating - that's bad.

Also, I must confess that I am not so sure if it's a good idea at all to write this data to the session. I find it rather disturbing. E.g. I set up some strange filter combination or list limit, do something else, and then go back to the list to find the same strange configuration. But maybe that's just me.

Right now it's broken, so the issue should stay open ;)

avatar - close - 24 Nov 2012
avatar elkuku
elkuku - comment - 24 Nov 2012

Since the solution proposed here no longer applies - closed until we have something working ;)

avatar elkuku elkuku - close - 24 Nov 2012
avatar elkuku elkuku - head_ref_deleted - 3 Mar 2016

Add a Comment

Login with GitHub to post a comment