enhancement Pending

User tests: Successful: Unsuccessful:

avatar elkuku
elkuku
10 Oct 2012

This will refactor com_users (site) so it doesn't need the legacy classes any more. I think we might need the models in other places.

Also fixes the message queue during redirects

avatar elkuku elkuku - open - 10 Oct 2012
avatar elkuku elkuku - open - 10 Oct 2012
avatar mbabker
mbabker - comment - 10 Oct 2012

Just at a quick glance, it looks good. After I get dinner, I'll test this out some. I did notice a couple of things though.

  • Two of the CLI scripts have their permissions changed from 644 to 755, any reason?
  • GitHub says the pull can't be merged automatically. Not a biggie (odds are I'll merge locally once I pull the code down), but just a heads up if you get the chance to look at it before me.
avatar elkuku
elkuku - comment - 11 Oct 2012

The permission change is due to setting the executable bit on the files. Otherwise the whole shebang would be useless ;)
And I believe that's the conflict for the auto-merge.. try again now please ;)

avatar - close - 11 Oct 2012
avatar mbabker mbabker - reference | - 11 Oct 12
avatar mbabker mbabker - merge - 11 Oct 2012
avatar mbabker mbabker - close - 11 Oct 2012
avatar mbabker
mbabker - comment - 11 Oct 2012

Didn't get to fully test as I'd hoped, but I'm not gonna wait to merge this until it's fully tested. We got plenty of time to hash that out ;-)

avatar mbabker mbabker - reference | - 24 Apr 13
avatar elkuku elkuku - head_ref_deleted - 3 Mar 2016

Add a Comment

Login with GitHub to post a comment