[#9998] - Number validation as global handler
- Closed
- 21 May 2017
- Medium
- Build: staging
- # 9998
- Diff
- jackkum:number-validation
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #5619 .
Summary of Changes
- Added handler for the number field validation
- Minified uncompressed file
Testing Instructions
- Go to the Joomla administration
- Then: System => Global Configuration => System (Tab) => Session Settings
- Try input in the field 'Session Lifetime' zero or negative value
You should see error (red border around and title on mouseover)
This PR add handler as global, only for session lifetime (com_config) here: #9997
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Fields JavaScript |
| Rel_Number | 0 | ⇒ | 5619 |
| Relation Type | ⇒ | Pull Request for |
I'd love to, but probably not in this PR, because it would break git diffs (all lines would show as changed).
Looks like 2x tabs or eventually 8x space would fit current CS here (ATM there is space + tab + space + tab 
).
Hm, why it names "number" validation? I see only some "range" validation.
It will return true for the string that not a number.
Need a PR for add class="validate-range" in a file administrator/components/com_config/model/form/application.xml for the field lifetime.
@jackkum Sorry I dont understand your last comment
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9998.
| Status | Pending | ⇒ | Information Required |
@brianteeman
By @Fedik advice i renamed number to range and validation on client side for the field lifetime will not be applied, so need a PR for this.
Sorry for my English.
| Status | Information Required | ⇒ | Pending |
Can you please mention the Both scenario before patch and after patch, as i tested and it seems working same in both cases
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9998.
I have tested this PR in Joomla! 3.6.4, before patch and after patch the session field is working same in bath scenarios.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/9998.
I have tested this item
Before and after Patch works in same Way.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/9998.
@jackkum it has been six months since the first request to resolve the merge conflicts. Also as several people have reported that they cannot see any difference after applying the PR I am going to close this at this time. It can always be reopened if you resolve the conflicts and address the comments about no change after this PR
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-21 17:37:04 |
| Closed_By | ⇒ | brianteeman |
Could you use 4 spaces as described here?
This file is really botched in terms of indentation
