? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
15 Apr 2016

Pull Request for Issue #9911

Menu items of type alias, separator, url or heading should not be presented as possible association when editing a menu item.

To test, create a simple multilanguage site (2 languages are enough), enable associations. Create menus in 2 languages, in each of them create menu items to usual contents, switch to the Associations tab and try to associate them to a menu in the other language. All menu items, including alias, separator, url or heading can be chosen in the list.

After patch, you will not be able anymore.

you will get for example:
screen shot 2016-04-15 at 12 34 31

Also this patch does not display the Associations tab for the same menu items (after saving the menu item):
screen shot 2016-04-15 at 13 01 31

avatar infograf768 infograf768 - open - 15 Apr 2016
avatar infograf768 infograf768 - change - 15 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2016
Labels Added: ?
avatar infograf768
infograf768 - comment - 15 Apr 2016

An improvement would be to display or not the Associations tab on the fly after choosing a menu item type. Over my head :smiley:

avatar brianteeman brianteeman - change - 15 Apr 2016
Easy No Yes
avatar brianteeman brianteeman - change - 15 Apr 2016
Category Administration Multilanguage
avatar Simonkloostra Simonkloostra - test_item - 15 Apr 2016 - Tested successfully
avatar Simonkloostra
Simonkloostra - comment - 15 Apr 2016

I have tested this item :white_check_mark: successfully on 65be5f8

Tested succesfully: After applying the patch, it is no longer possible to associate with Menu-item Alias. Also, Menu-item Alias does not show an option to Associate with nything else, the tab is gone.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9929.

avatar cheiff cheiff - test_item - 15 Apr 2016 - Tested successfully
avatar cheiff
cheiff - comment - 15 Apr 2016

I have tested this item :white_check_mark: successfully on 65be5f8

I tested this successfully.
I can confirm that on the associations combo all system links menu items are shown in gray and cannot be selected, with the exception of menu alias that do not appear at all (correct).
I can also confirm that the associations tab does not appear in any of these items anymore.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9929.

avatar larapetersen
larapetersen - comment - 15 Apr 2016

Tested succesfully.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9929.

avatar larapetersen larapetersen - test_item - 15 Apr 2016 - Tested successfully
avatar larapetersen
larapetersen - comment - 15 Apr 2016

I have tested this item :white_check_mark: successfully on 65be5f8


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9929.

avatar infograf768 infograf768 - change - 15 Apr 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 15 Apr 2016

rtc
as this was a bug, i suggest to merge in 3.5.2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9929.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 15 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - change - 15 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-15 18:54:43
Closed_By rdeutz
avatar rdeutz rdeutz - close - 15 Apr 2016
avatar rdeutz rdeutz - merge - 15 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 15 Apr 2016
avatar rdeutz rdeutz - reference | bf90287 - 15 Apr 16
avatar rdeutz rdeutz - merge - 15 Apr 2016
avatar rdeutz rdeutz - close - 15 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2016
Labels Removed: ?
avatar infograf768 infograf768 - head_ref_deleted - 17 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment