? Success

User tests: Successful: Unsuccessful:

avatar GABBAR1947
GABBAR1947
15 Apr 2016

Pull Request for Issue #9822

avatar GABBAR1947 GABBAR1947 - open - 15 Apr 2016
avatar GABBAR1947 GABBAR1947 - change - 15 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 15 Apr 2016

Please do NOT edit the css file directly.

You must edit the less file and then run the generatess.php to update the css

avatar brianteeman brianteeman - change - 15 Apr 2016
Category Templates (admin)
avatar brianteeman brianteeman - change - 15 Apr 2016
Title
improved modal layout
improved modal layout
avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Apr 2016

Just checking the code i think this will add a padding-top: 12px; to ALL the form that uses the .form-horizontal .control-group css class...

avatar brianteeman
brianteeman - comment - 15 Apr 2016

Yes this is not the correct solution at all

On 15 April 2016 at 12:49, andrepereiradasilva notifications@github.com
wrote:

Just checking the code i think this will add a padding-top: 12px; to ALL
the form with that uses the .form-horizontal .control-group css class...


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#9930 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar GABBAR1947
GABBAR1947 - comment - 15 Apr 2016

@brianteeman working on it !

avatar GABBAR1947
GABBAR1947 - comment - 15 Apr 2016

So ,should I create a new class for this particular form so that the other forms don't get affected ?

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Apr 2016

i think the problem you're referring only applies to tinymce modals.
And this is not the way to solve that problem because it would have side effects.

IMHO you should close this and take time to think of a way of solving the problem without the side effects.

avatar rdeutz rdeutz - change - 16 Apr 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-16 20:32:55
Closed_By rdeutz
avatar rdeutz rdeutz - close - 16 Apr 2016
avatar rdeutz rdeutz - merge - 16 Apr 2016
avatar rdeutz rdeutz - merge - 16 Apr 2016
avatar rdeutz rdeutz - close - 16 Apr 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Apr 2016

@rdeutz why did you merge this? It has no tests and it will have side effects.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Apr 2016

ok, i see, this was not merged although github thinks so because this one #9946 was merged .

avatar rdeutz
rdeutz - comment - 17 Apr 2016

Strange, isn't it? Bug in Github?

avatar zero-24
zero-24 - comment - 17 Apr 2016

It is because both PRs include this commit: GABBAR1947@890f048

And @rdeutz merged the other PR.

Add a Comment

Login with GitHub to post a comment