[#9928] - Fixed overwritten properties
- Fixed in Code Base
- 19 Apr 2016
- Medium
- Build: staging
- # 9928
- Diff
- demis-palma:fix-beez-css
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Fixed overwritten properties
- Removed redundant unit of measure
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Without any real test instructions nothing will happen with this.
With good test instructions at least explaining what can be seen before and
after this PR it will get tested quickly
On 15 April 2016 at 11:59, andrepereiradasilva notifications@github.com
wrote:
the 0pxto 0of course.
regarding the rest, test instructions?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#9928 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@andrepereiradasilva thanks for asking. I'm sorry for the lack of details.
I only removed a bounce of duplicated occurrences of identical instructions, for example
line-height: 1.6em;
and 3 lines after
line-height: 1.6em;
or others slightly different
border: solid 1px;
and 2 lines after
border: 1px solid #DDDDDD;
where the second overwrites and prevales over the first
or again
margin: 0;
and 2 lines after
margin: 0 0 0;
It is well visible with a good diff program.
I can't think about a test except checking that the templates renders the same as before.
It's only an optimization, it should not produce any visible effect.
| Category | ⇒ | Templates (site) |
I have tested this item 
successfully on 58d8372
Makes sense.
Removes duplicated css and makes micro-optimizations to css.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9928.
I have tested this item successfully on 58d8372
deskcheck and small regressiontest
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9928.
Thanks!
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-19 11:36:35 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
the
0pxto0of course.regarding the rest, test instructions?