?
Referenced as Pull Request for: # 9864
avatar brianteeman
brianteeman
11 Apr 2016

Steps to reproduce the issue

The redirect component has a fairly hidden feature to mass update existing links - its at the bottom of the list called Destination URL.
Select some existing links and click on Destination URL
Enter a new Destination URL and a comment
And then update links button to process

Expected result

Destination url is changed
comment is added
Last Updated Date is modified

Actual result

Destination url is changed
comment is added
Last Updated Date is unchanged

avatar brianteeman brianteeman - open - 11 Apr 2016
avatar polakluk polakluk - reference | 535436e - 11 Apr 16
avatar brianteeman brianteeman - change - 11 Apr 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-04-11 23:04:08
Closed_By brianteeman
avatar brianteeman
brianteeman - comment - 11 Apr 2016

Closed as we have a PR #9864


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9859.

avatar brianteeman brianteeman - close - 11 Apr 2016
avatar brianteeman brianteeman - close - 11 Apr 2016
avatar polakluk
polakluk - comment - 11 Apr 2016

My PR should fix the issue. However, when I looked at the code, one thing startled me - the way "Destination URL" works right now is that it automatically enables the changed URLs (even if they were disabled prior to the operation). I will update documentation to mention this functionality.

avatar brianteeman
brianteeman - comment - 11 Apr 2016

That sounds like another bug to me

avatar polakluk
polakluk - comment - 11 Apr 2016

Yeah, I looked at the documentation closely and it never mentions it. So I will post another PR to fix that as well. Before that, I need to figure out what happend in Travis with #9864

avatar brianteeman
brianteeman - comment - 11 Apr 2016

178 | ERROR | Whitespace found at end of line

avatar polakluk
polakluk - comment - 11 Apr 2016

I just found it too (facepalm)

avatar brianteeman
brianteeman - comment - 11 Apr 2016

I can confirm the bug that all updated links are set to published.

avatar polakluk
polakluk - comment - 11 Apr 2016

Should I create a separate Github issue for that one, or simply fix it and add it to the #9864 PR?

avatar brianteeman
brianteeman - comment - 11 Apr 2016

up to you. but guessing at what the fix is I would do it in the same PR

Add a Comment

Login with GitHub to post a comment