[#9858] - Redirect batch
- Fixed in Code Base
- 15 Apr 2016
- Medium
- Build: staging
- Easy Test
- # 9858
- Diff
- brianteeman:redirect-batch
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 6 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
The redirect component has a batch function to allow you to mass insert a set of urls. However this uses the common batch.php layout which has some javascript to ensure that you have selected one or more items to batch edit first.
As the batch functionality in com_redirect works completely differently to all other batch buttons and does not require (or need) you to select an existing item first it was not working correctly.
To resolve this I created a new layout "batchredirect" which doesnt have the javascript check.
Test instructions
Go to com_redirect and click the batch button on the toolbar - you will get a message about selecting an item first
Select an item and click the batch button. The modal will open and you can type new links on each line and when you click process you will see that new links have been created without any reference to the item you selected.
Apply the patch and you can click the batch button as intended without preselecting an irrelevant link first
Also check that this works when you do not have any redirects created.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | Components Layout |
| Easy | No | ⇒ | Yes |
I have tested this item 
successfully on e4d0d63
Prefer also to name Button "Batch" with another Name, cause "Batch" means in other Places different to this Button-Name.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9858.
@brianteeman Will you add a changed name for the button into this PR or that is for another PR?
I have tested this item successfully on e4d0d63
Successful (still the name issue remains) - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9858.
| Status | Pending | ⇒ | Ready to Commit |
RTC - thanks
@roland-d no i will not be creating a PR to change the name of the button. Got too much abuse last time not going to do that again
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9858.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
@brianteeman can we make this a component specific layout rather than a global one please?
This PR has received new commits.
CC: @franz-wohlkoenig, @MATsxm
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9858.
| Labels |
Removed:
?
|
||
| Labels |
Added:
?
|
||
Do not test yet
@wilsonge - tried to do what you asked but something isnt quite right. i
assumed i missed something obvious
On 14 April 2016 at 20:40, Joomla! CMS Bot notifications@github.com wrote:
This PR has received new commits.
CC: @franz-wohlkoenig https://github.com/franz-wohlkoenig, @MATsxm
https://github.com/MATsxm
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/9858
https://issues.joomla.org/tracker/joomla-cms/9858.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9858 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
| Status | Ready to Commit | ⇒ | Pending |
| Labels | |||
Removed RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9858.
| Labels |
Removed:
?
|
||
There is a problem that the toolbar will not do anything if you dont have any existing redirects. I cant see where this problem lies
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9858.
This PR has received new commits.
CC: @franz-wohlkoenig, @MATsxm
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9858.
Fixed the bug it is ready for testing again
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9858.
I have tested this item successfully on d5a9c91
TEST OK
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9858.
I have tested this item successfully on d5a9c91
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9858.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
I have tested this item successfully on d5a9c91
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9858.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-15 12:17:23 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item 
unsuccessfully on d5a9c91
The Redirect Plugin is enabled. The option 'Collect URLs' is enabled.
.htaccess should be used.
Batch process can be applied with and without any redirect records.
No pre-selection is required.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9858.
Sorry, I ment Succesfull test
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9858.
I have tested this item successfully on d5a9c91
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9858.
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
Note: it might be better to rename this button from batch to "bulk import"
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9858.