User tests: Successful: Unsuccessful:
Pull Request for Issue #9859 & #9873.
Added code to update "modified_date" when doing bulk update for Destination URL do Link model. Also, the "Destination URL" functionality was moved into a separate method in model in order to fix #9873 in clear way.
(Copied from the original issue)
The redirect component has a fairly hidden feature to mass update existing links - its at the bottom of the list called Destination URL.
Select some existing links and click on Destination URL
Enter a new Destination URL and a comment
And then update links button to process
Destination url is changed
comment is added
Last Updated Date is modified
(Copied from the original issue)
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Category | ⇒ | Components |
Rel_Number | 0 | ⇒ | 9859 |
Relation Type | ⇒ | Pull Request for | |
Easy | No | ⇒ | Yes |
This PR has received new commits.
CC: @brianteeman
I have tested this item successfully on b059fb1
works as described.
I have tested this item successfully on b059fb1
@polakluk Once Travis is happy this can be made RTC
178 | ERROR | Whitespace found at end of line
travis is already happy
Status | Pending | ⇒ | Ready to Commit |
RTC - thanks - travis took a little while to update the issue tracker ;)
Labels |
Added:
?
|
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
This PR has received new commits.
CC: @andrepereiradasilva, @brianteeman, @MATsxm
This PR has received new commits.
CC: @andrepereiradasilva, @brianteeman, @MATsxm
This PR has received new commits.
CC: @andrepereiradasilva, @brianteeman, @MATsxm
Now you added new methods ... and i think that means it will go only for 3.6.
I would prefer to keep them separated, this one was already tested and RTC... but, of course, it's your choice.
My intention was to keep merging process simple. Since these changes occur in the same file, it is easier to apply one PR to code base than having to merge 2 separate PR and keeping in mind their order (the second part of this PR reverts the change made in the first commit). I am sorry for committing the code after the original PR was already tested. If it causes more trouble than it fixes, then I can create a separate PR for this.
I didnt know that once new methods are added, the patch will be schedule for the next minor version. If that is indeed true, then I can change the comments
I didnt know that once new methods are added, the patch will be schedule for the next minor version. If that is indeed true, then I can change the comments
I'm not sure that it's how it works? is it? @brianteeman
This PR has received new commits.
CC: @andrepereiradasilva, @brianteeman, @MATsxm
@polakluk I have tested. The expected result is okay, but the create date and the last modify date are always GMT time. Check this, if you change the server time zone. You can this compare with the create date an modify date from article.
@polakluk I have the items trashed and the trash is empty. But the redirect function is still running! The database table is also empty. Is this a cookie problem?
@teccrow
I checked the first one and you're right. The fields always show GTM time, because that's how the time is stored (correctly) in DB. However, this seems to be a behavior that is consistent across all parts of Joomla admin (check Articles for example), so this may be intentional. I would like to hear second opinion on this.
As for your second comment. I am still testing it, because my local Joomla installation is wierdly acting out right now.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-12 20:39:05 |
Closed_By | ⇒ | rdeutz |
Labels |
Removed:
?
|
ups, ok, would be great if you can test, we can revert it if test fail, thanks @andrepereiradasilva
Tested successfully. So it seems it was a good merge :)
@polakluk Correct, the is stored GMT in DB. But, if the Server Time (global Configuration) set for example on 'Berlin' than all Times show in Berlin Time. The form field 'created_date' and 'modify_date' are to be changed.
For example:
<field
name="created_date"
type="calendar"
label=""
description=""
format="%Y-%m-%d %H:%M:%S"
size="20"
readonly="true"
filter="user_utc" />
Important are the type and the filter!
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
I have tested this item successfully on 535436e
Thanks - I should have worked that fix out myself ;)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9864.