? Success
Pull Request for # 9859

User tests: Successful: Unsuccessful:

avatar polakluk
polakluk
11 Apr 2016

Pull Request for Issue #9859 & #9873.

Summary of Changes

Added code to update "modified_date" when doing bulk update for Destination URL do Link model. Also, the "Destination URL" functionality was moved into a separate method in model in order to fix #9873 in clear way.

Testing Instructions #9859

(Copied from the original issue)

Steps to reproduce the issue

The redirect component has a fairly hidden feature to mass update existing links - its at the bottom of the list called Destination URL.
Select some existing links and click on Destination URL
Enter a new Destination URL and a comment
And then update links button to process

Expected result

Destination url is changed
comment is added
Last Updated Date is modified

Testing Instructions #9873 (ADDED LATER)

(Copied from the original issue)

Steps to reproduce the issue
  1. Go to "Redirect" component in back-end and select some URLs (some of them should be disabled)
  2. Click on link "Destination URL" (below table)
  3. Enter some URL
  4. Leave "Comment" field empty
  5. Click on "Update links"
Expected result
  • Selected rows will have new URL
  • Their state (Enabled/disabled) will remain the same
  • Their comment will remain the same
avatar polakluk polakluk - open - 11 Apr 2016
avatar polakluk polakluk - change - 11 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 11 Apr 2016
Category Components
avatar brianteeman brianteeman - change - 11 Apr 2016
Rel_Number 0 9859
Relation Type Pull Request for
Easy No Yes
avatar brianteeman brianteeman - test_item - 11 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 11 Apr 2016

I have tested this item :white_check_mark: successfully on 535436e

Thanks - I should have worked that fix out myself ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9864.

avatar joomla-cms-bot
joomla-cms-bot - comment - 11 Apr 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9864.

avatar andrepereiradasilva andrepereiradasilva - test_item - 11 Apr 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Apr 2016

I have tested this item :white_check_mark: successfully on b059fb1

works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9864.

avatar MATsxm MATsxm - test_item - 11 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 11 Apr 2016

I have tested this item :white_check_mark: successfully on b059fb1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9864.

avatar brianteeman
brianteeman - comment - 11 Apr 2016

@polakluk Once Travis is happy this can be made RTC

178 | ERROR | Whitespace found at end of line


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9864.

avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Apr 2016

travis is already happy

avatar brianteeman brianteeman - change - 11 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 11 Apr 2016

RTC - thanks - travis took a little while to update the issue tracker ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9864.

avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 11 Apr 2016
Milestone Added:
avatar brianteeman brianteeman - change - 11 Apr 2016
Milestone Added:
avatar brianteeman brianteeman - change - 11 Apr 2016
Milestone Removed:
avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Apr 2016

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9864.

avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Apr 2016

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9864.

avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Apr 2016

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9864.

avatar polakluk
polakluk - comment - 12 Apr 2016

I added code that also fixes #9873 to this PR in order to keep it in one place

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Apr 2016

Now you added new methods ... and i think that means it will go only for 3.6.

I would prefer to keep them separated, this one was already tested and RTC... but, of course, it's your choice.

avatar polakluk
polakluk - comment - 12 Apr 2016

My intention was to keep merging process simple. Since these changes occur in the same file, it is easier to apply one PR to code base than having to merge 2 separate PR and keeping in mind their order (the second part of this PR reverts the change made in the first commit). I am sorry for committing the code after the original PR was already tested. If it causes more trouble than it fixes, then I can create a separate PR for this.

I didnt know that once new methods are added, the patch will be schedule for the next minor version. If that is indeed true, then I can change the comments

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Apr 2016

I didnt know that once new methods are added, the patch will be schedule for the next minor version. If that is indeed true, then I can change the comments

I'm not sure that it's how it works? is it? @brianteeman

avatar polakluk polakluk - change - 12 Apr 2016
The description was changed
avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Apr 2016

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9864.

avatar teccrow
teccrow - comment - 12 Apr 2016

@polakluk I have tested. The expected result is okay, but the create date and the last modify date are always GMT time. Check this, if you change the server time zone. You can this compare with the create date an modify date from article.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9864.

avatar teccrow
teccrow - comment - 12 Apr 2016

@polakluk I have the items trashed and the trash is empty. But the redirect function is still running! The database table is also empty. Is this a cookie problem?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9864.

avatar polakluk
polakluk - comment - 12 Apr 2016

@teccrow
I checked the first one and you're right. The fields always show GTM time, because that's how the time is stored (correctly) in DB. However, this seems to be a behavior that is consistent across all parts of Joomla admin (check Articles for example), so this may be intentional. I would like to hear second opinion on this.

As for your second comment. I am still testing it, because my local Joomla installation is wierdly acting out right now.

avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar rdeutz rdeutz - change - 12 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-12 20:39:05
Closed_By rdeutz
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 12 Apr 2016
avatar rdeutz rdeutz - reference | f8ee8de - 12 Apr 16
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Removed: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Apr 2016

@rdeutz i think this one was merged by mistake, the latest big changes were not tested.

let's hope this does not introduces any issue. will test tomorrow.

avatar rdeutz
rdeutz - comment - 13 Apr 2016

ups, ok, would be great if you can test, we can revert it if test fail, thanks @andrepereiradasilva

avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Apr 2016

Tested successfully. So it seems it was a good merge :)

avatar teccrow
teccrow - comment - 15 Apr 2016

@polakluk Correct, the is stored GMT in DB. But, if the Server Time (global Configuration) set for example on 'Berlin' than all Times show in Berlin Time. The form field 'created_date' and 'modify_date' are to be changed.
For example:

    <field 
        name="created_date"
        type="calendar"
        label=""
        description=""
        format="%Y-%m-%d %H:%M:%S"
        size="20"
        readonly="true"
        filter="user_utc" />

Important are the type and the filter!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9864.

avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment