? Pending

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
12 Mar 2016

Pull Request for Issue #9392.

Summary of Changes

The #9392 issue itself, as commented in the issue is not a regression, but joomla update should not find joomla updates if there is no download url.

image

Testing Instructions

  1. Clean install of this joomla version https://developer.joomla.org/cms-packages/Joomla_3.5.0-beta6-dev-Beta-Full_Package.zip
  2. After install go to joomla update
  3. In the options switch the core update URL to "Test"
  4. You will get an update with the error in the image above
  5. Apply patch
  6. Go to joomla update and clear the cache: you will get no update.

Observations

I'm not sure if this has any other consequence in the joomla update.
So, besides the 2 tests, i ask also for a review of someone that fully understand the joomla update.

@mbabker what do you think?

avatar andrepereiradasilva andrepereiradasilva - open - 12 Mar 2016
avatar mbabker
mbabker - comment - 12 Mar 2016

Seems like you're masking a deeper level issue in the update library. Correct this would presumably hide a possible update if a download URL can't be found, but why is Joomla thinking there's an update if there isn't a full update record?

FWIW, you can get this scenario right now because George added a line for 3.5 to http://update.joomla.org/core/test/list_test.xml for some other testing but the extension XML doesn't have a corresponding compatible record.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Mar 2016

ok, i see, so this is not the best approach for this.

There is something in JUpdater that is returning the $this->updateInfo['object'] even without anything... but since it's not NULL joomla thinks there is an update.

this is what i get in the error scenario above in a <?php var_dump($this->updateInfo['object']); ?>

object(JUpdate)#217 (22) {
  ["name":protected]=>  NULL
  ["description":protected]=>  NULL
  ["element":protected]=>  NULL
  ["type":protected]=>  NULL
  ["version":protected]=>  NULL
  ["infourl":protected]=>  NULL
  ["client":protected]=>  NULL
  ["group":protected]=>  NULL
  ["downloads":protected]=>  NULL
  ["tags":protected]=>  NULL
  ["maintainer":protected]=>  NULL
  ["maintainerurl":protected]=>  NULL
  ["category":protected]=>  NULL
  ["relationships":protected]=>  NULL
  ["targetplatform":protected]=>  NULL
  ["extra_query":protected]=>  NULL
  ["xmlParser":protected]=>  resource(148) of type (Unknown)
  ["stack":protected]=>  array(1) {    [0]=>    string(4) "base"  }
  ["stateStore":protected]=>  array(0) {  }
  ["latest":protected]=>  NULL
  ["minimum_stability":protected]=>  int(4)
  ["_errors":protected]=>  array(0) {  }
}

Updated: the old code was from another dump

avatar andrepereiradasilva andrepereiradasilva - change - 12 Mar 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-03-12 22:46:52
Closed_By andrepereiradasilva
avatar andrepereiradasilva andrepereiradasilva - close - 12 Mar 2016
avatar joomla-cms-bot joomla-cms-bot - close - 12 Mar 2016
avatar joomla-cms-bot joomla-cms-bot - change - 12 Mar 2016
Labels Added: ?

Add a Comment

Login with GitHub to post a comment