? Success

User tests: Successful: Unsuccessful:

avatar JoomliC
JoomliC
12 Mar 2016

Fix the "Hide Sidebar" tooltip text, after changing page with sidebar already hidden.

Summary of Changes

Remove default title attribute (JHtml::tooltipText('JTOGGLE_HIDE_SIDEBAR')) in Toggle layout, as set by template.js

Testing Instructions

  • Go to Articles (or any admin page where there's the collapsible sidebar).
  • Hide the Sidebar (see the tip is now show)
  • Go to Categories (or any admin page where there's the collapsible sidebar)
  • Sidebar is still closed (expected behavior!) but if you mouseover the sidebar icon, the tooltip text is wrong (see the tip is now hide, but should be Show)

Current behavior

Tooltip text is "Hide the sidebar" (but the sidebar is hidden!)

Expected behavior

Tooltip text is "Show the sidebar" when sidebar is hidden

After Patch

After this patch, it's fixed, and tooltip text is as expected.

avatar JoomliC JoomliC - open - 12 Mar 2016
avatar JoomliC JoomliC - change - 12 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - test_item - 12 Mar 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 Mar 2016

I have tested this item :white_check_mark: successfully on 6a32170

Took me a while to work out that you have to do something like
1) go to article manager and hide column (see the tip is now show)
2) go to category manager - the column is already hidden but the tip is still hide

The PR fixes it


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9395.

avatar JoomliC
JoomliC - comment - 12 Mar 2016

@brianteeman sorry if it was not clear...
I have updated the description, if it could help better.

avatar zero-24 zero-24 - test_item - 13 Mar 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 13 Mar 2016

I have tested this item :white_check_mark: successfully on 6a32170

Works good here. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9395.

avatar brianteeman brianteeman - change - 13 Mar 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 13 Mar 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9395.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 22 Mar 2016
Category Templates (admin) UI/UX
avatar brianteeman brianteeman - change - 22 Mar 2016
Labels
avatar brianteeman brianteeman - change - 12 Apr 2016
Milestone Added:
avatar brianteeman brianteeman - change - 12 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - change - 13 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-13 05:32:22
Closed_By rdeutz
avatar rdeutz rdeutz - close - 13 Apr 2016
avatar rdeutz rdeutz - merge - 13 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 13 Apr 2016
avatar rdeutz rdeutz - reference | df49fe9 - 13 Apr 16
avatar rdeutz rdeutz - merge - 13 Apr 2016
avatar rdeutz rdeutz - close - 13 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2016
Labels Removed: ?
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment