[#9397] - [CS] fixes: Need empty line before the return statement;
- Fixed in Code Base
- 12 Mar 2016
- Medium
- Build: staging
- # 9397
- Diff
- photodude:patch-3
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for code style issue.
Summary of Changes
Need empty line before the return statement;
Testing Instructions
No testing necessary; should be merged by code review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-12 22:24:30 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
@JoomliC Normally I would try to keep something like this to a single PR (I also try to avoid modifying a PR after submitting it unless it's necessary). Each of these came up while I was reviewing a test of the Draft for a PHPCS2 version of the coding standards and without a local copy of the CMS and github to work from. My focus and attention was on dealing with the coding standards compliance in the draft.
@photodude no problem for me ;-)
Was just surprised when arrived on issue tracker on my iPhone, thought of a issue tracker bug !
Why you don't do that all in 1 PR ?
#9397 , #9398 , #9399 , #9400 ...
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9397.