[#9233] - Menu Assignment tree closing before complete
- Closed
- 27 Feb 2016
- Medium
- Build: master
- # 9233
Steps to reproduce the issue
Create a module (I created a Custom HTML module)
Create a large number of nested menus with nested menu items
Open the module menu assignment tab to assign locations.
Expected result
The menu tree is correctly rendered.
Actual result
The menu tree is only partially rendered correctly.
System information (as much as possible)
OS Linux s
PHP 5.6.18
MySQLi 5.5.31-30.3-log
Web server: Apache/2.2.24 (Unix) mod_hive/5.0 mod_ssl/2.2.24 OpenSSL/1.0.0-fips mod_auth_passthrough/2.1 mod_bwlimited/1.4 mod_fastcgi/2.4.6 mod_fcgid/2.3.6
Joomla! 3.4.8 Stable [ Ember ] 24-December-2015 19:30 GMT
Additional comments
See the attached screenshot showing multiple menus. The first menus and their menu items render correctly. But where a new menu starts, the closing <ul> tag is added prematurely. The list continues and it breaks both usage and display.
Also attached below is a code sample of that section of the page. The top part of the page (down to line 4000 or so) is correct, but the closing tag is added here instead of at the end of the <li> list.
| Status | New | ⇒ | Information Required |
Verified as still a bug in current staging.
Weird as I dont see it - maybe I am not following your instructions correctly
No, I'm not using Advanced Module Manager.
Do this to reproduce in staging:
- Do a fresh install.
- Replace the two default menu tables ( *_menu and *_menu_types) with a large multi-layer menu. See the attached SQL script. Make sure to update the table prefix to your own (no, that's not mine in the file).
- Create a new custom module and try to assign a menu item.
Thanks Ron. I will retest with your supplied data in the morning
On 27 Feb 2016 8:59 pm, "Ron Severdia" notifications@github.com wrote:
No, I'm not using Advanced Module Manager.
Do this to reproduce in staging:
- Do a fresh install.
- Replace the two default menu tables ( *_menu and *_menu_types) with a large multi-layer menu. See the attached SQL script. Make sure to update the table prefix to your own (no, that's not mine in the file).
- Create a new custom module and try to assign a menu item.
menu_tables.sql.zip
https://github.com/joomla/joomla-cms/files/149555/menu_tables.sql.zip—
Reply to this email directly or view it on GitHub
#9233 (comment).
The good news is that I have imported the data and can see what you mean.
However the data is showing something else that is odd. If you try to collapse all the menus you can see that the "other menu" doesnt collapse properly.
This suggested to me that it was an issue in your "other menu" and nothing to do with the nested menus in the "plays menu". To test this theory I trashed the "other menu" and proved my theory as the "plays menu" now displays correctly.
Conclusion there is nothing wrong with Joomla - the problem is somewhere in your database
Yes, I've just discovered in the Other menu there are menu items where a level is missing.
Under "Reviews Extra" there are four menu item aliases that are somehow not mapped to a parent. Opening and re-saving those items fixed the issue. I'll close this. Thank you.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-27 23:00:02 |
| Closed_By | ⇒ | severdia |
No problem glad to have helped
On 27 Feb 2016 11:00 pm, "Ron Severdia" notifications@github.com wrote:
—
Reply to this email directly or view it on GitHub
#9233 (comment).
| Labels |
Added:
?
|
||
Please can you retest against the current staging - I can't replicate this issue and I seem to recall this being resolved in a previous PR
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9233.