I have tested this item successfully on ba84682

Tested successfully - I still see zero value in the style box

I still see zero value in the style box

sorry, didn't understand your comment.

Dont worry about it - just personally dont see the need to add a style here
as I think it is better to be done in the module and just confuses the UI
here with a function right at the top that is not easy to understand or
even that most people will even have a clue what it is for

On 28 February 2016 at 13:06, andrepereiradasilva notifications@github.com
wrote:

I still see zero value in the style box

sorry, didn't understand your comment.

—
Reply to this email directly or view it on GitHub
#9232 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

I have tested this item successfully on ba84682

Test OK

RTC thanks

Hi, i want to contribute by testing this PR.
I have a ques and this may seem silly to some. What does the term latest staging means?

Means the latest "version" on the current branch "staging" it contains all
pr merged
On 2 Mar 2016 8:39 am, "Shubham Rajput" notifications@github.com wrote:

Hi, i want to contribute by testing this PR.
I have a ques and this may seem silly to some. What does the term latest
staging means?

—
Reply to this email directly or view it on GitHub.

The term 'staging' refers to something that's staged to be delivered.

In Joomla context, it is the name of all the latest accepted changes.

Then, to test a new change, you have to download from Github the latest
staging (click in the main repo Download button) and install that version
for testing.

Additionally, some PRs provide the whole Joomla to avoid the hassle of
patching.

Happy testing !
On Mar 2, 2016 8:39 AM, "Shubham Rajput" notifications@github.com wrote:

Hi, i want to contribute by testing this PR.
I have a ques and this may seem silly to some. What does the term latest
staging means?

—
Reply to this email directly or view it on GitHub
#9232 (comment).

Just one more small doubt. I have installed joomla version 3.4.8 and using xampp to run it.
So lnstalling latest versiofromn means I have to download latest version github then remove 3.4.8 version and then install latest version of joomla? Is this the procedure or I can upgrade the 3.4.8 version without removing it? Thanks in advance

Both procedures are valid. However, if you upgrade from 3.4.8, then you are
also testing the upgrade.

• In most cases, it is better to download the whole staging
  https://github.com/joomla/joomla-cms/archive/staging.zip and test only PRs.
  In this way, you optimize your time and it is easier to isolate cases and
  results.

• If you are testing the upgrade itself, then you have to test the
  upgrading process. For example, this PR #9221 was hot because J3.5 is going
  to apply a new MySQL collation (utf8mb4) to certain tables. In this case,
  the PR has the steps to apply the upgrade, since it had several (and more
  comlex) steps and combined with other associated PRs.

According to my experience, it is simpler to start from staging.zip
https://github.com/joomla/joomla-cms/archive/staging.zip and test "easy"
issues:

https://issues.joomla.org/tracker/joomla-cms/?state=open&sort=issue&direction=desc&tests=3&easytest=1&stools-active=1
https://github.com/joomla/joomla-cms/archive/staging.zip

Can we solve conflicts here please :)

This PR has received new commits.

CC: @anibalsanchez, @brianteeman

This PR has received new commits.

CC: @anibalsanchez, @brianteeman

ignore again the unit tests label, somehow my git changed the filename of the xcache unit test, i reverted.
Seems my git has some issues with the naming of that file, maybe because is windows...

Conflicts fixed. @brianteeman please remove again the label sorry.

Two questions:

1) Why was the type column removed?
2) Because it changes the interface, shouldn't this go into 3.6.x?

Dont know abut the removal of the type column (perhaps a mistake I only noticed the removal of the pages column which was meaningless) but this was only a "feature" added in 3.5.0 and to me its a bug fix/improvement

the type column is there is only hidden in tablet view.

As per your screenshot in the first post and a retest I just did right now which shows the same as your screenshot.
Type IS there in the search tools but is NOT there in the displayed columns which as shown in your own screenshots was there before

@brianteeman what was added in 3.5.0?

@rdeutz this a new plugin not present util 3.5.0 #8064

funny I have testet it, I am getting old :-), thanks

ok will check the type column, maybe the popup is a tablet size (width) and so it doesn't appear.

just tested, yes the popup is tablet size, i will change it.

This PR has received new commits.

CC: @anibalsanchez, @brianteeman

Done.

BTW not related to this PR, but the popups width shouldn't be fixed!

All good to me - will let @rdeutz decide on 3.5.2 or 3.6

I think this here is edge case and I plan to merge it into 3.5.2, because #9208, #9206, #9198 fixing bugs and should be merged in 3.5.2 and this one here would make the interface more consistent

thanks

On 13 April 2016 at 17:28, Robert Deutz notifications@github.com wrote:

I think this here is edge case and I plan to merge it into 3.5.2, because
#9208 #9208, #9206
#9206, #9198
#9198 fixing bugs and should
be merged in 3.5.2 and this one here would make the interface more
consistent

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9232 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

ok will fix the merge conflicts in the other 3 PR when i have time.