? ? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
27 Feb 2016

This PR to replace obsolete #8411
@brianteeman
@bertmert
@sural98
@andrepereiradasilva

To test on staging.

Only change vs #8411 is the Toolbar Title:
screen shot 2016-02-27 at 18 02 02

avatar infograf768 infograf768 - open - 27 Feb 2016
avatar infograf768 infograf768 - change - 27 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2016
Labels Added: ? ?
avatar infograf768 infograf768 - change - 27 Feb 2016
Easy No Yes
avatar infograf768 infograf768 - change - 27 Feb 2016
Category Administration UI/UX
avatar andrepereiradasilva andrepereiradasilva - test_item - 27 Feb 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 27 Feb 2016

I have tested this item :white_check_mark: successfully on 0605b12

Works fine.

I just have a consistency problem with this change.

In all other views, there is only one field (let's call it selector) that, is not inside the "Search filters": the client (or location). And this only exist in modules, cache and installed languages views.

That i know of, this is the only view that as a different selector: the menutype, but, if you have "- Select Menu -" option in theory is not a selector anymore as status, access, language and max levels are not. IMHO it turns itself into a search filter. And in that logic it should go inside search filters.
See, for instance, the example of the categories filter in articles view ...

PS: I know that this can be controversal. And don't want to hijack this PR with this, just leaving the thought here.

Marking as tested successfully as this PR works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

avatar infograf768
infograf768 - comment - 28 Feb 2016

As most operations and simple structure comprehension in this manager imply selecting a specific menu, I think we should keep the Select Menu separate.

avatar richard67 richard67 - test_item - 28 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 28 Feb 2016

I have tested this item :white_check_mark: successfully on 0605b12


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

avatar infograf768
infograf768 - comment - 29 Feb 2016

Thanks for testing. Bad luck this would be in 3.6.0 only :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

avatar infograf768 infograf768 - change - 29 Feb 2016
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - change - 29 Feb 2016
Labels Added: ?
avatar bertmert bertmert - test_item - 3 Mar 2016 - Tested unsuccessfully
avatar bertmert
bertmert - comment - 3 Mar 2016

I have tested this item :red_circle: unsuccessfully on 0605b12

- BE > Menu item manager.

  • Select a menu in dropdown select box.
  • In column Status click a button to unpublish a menu item.
  • Select box always falls back to entry "-Select menu--" and all menu items are shown.

Expected:

avatar infograf768 infograf768 - change - 3 Mar 2016
Status Ready to Commit Pending
avatar infograf768
infograf768 - comment - 4 Mar 2016

@bertmert
I confirm the issue. Taking off RTC for now.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

avatar joomla-cms-bot joomla-cms-bot - change - 4 Mar 2016
Labels Removed: ?
avatar joomla-cms-bot
joomla-cms-bot - comment - 4 Mar 2016

This PR has received new commits.

CC: @andrepereiradasilva, @bertmert, @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

avatar infograf768
infograf768 - comment - 4 Mar 2016

I have already a solution for setdefault Home which I am now merging.

To solve the publishing state, I did not find any other solution than overriding legacy/controller/admin.php publish() method.
If someone has a better idea, please let me know.

avatar joomla-cms-bot
joomla-cms-bot - comment - 4 Mar 2016

This PR has received new commits.

CC: @andrepereiradasilva, @bertmert, @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

avatar infograf768
infograf768 - comment - 4 Mar 2016

Now the publish() method is overriden. remains the Check-in one.

avatar joomla-cms-bot
joomla-cms-bot - comment - 4 Mar 2016

This PR has received new commits.

CC: @andrepereiradasilva, @bertmert, @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

avatar infograf768
infograf768 - comment - 4 Mar 2016

Please test again all toolbar buttons and Status icons. Issues should be now solved.

a1080a3 4 Mar 2016 avatar infograf768 cs
avatar joomla-cms-bot
joomla-cms-bot - comment - 4 Mar 2016

This PR has received new commits.

CC: @andrepereiradasilva, @bertmert, @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

avatar joomla-cms-bot
joomla-cms-bot - comment - 4 Mar 2016

This PR has received new commits.

CC: @andrepereiradasilva, @bertmert, @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

avatar bertmert
bertmert - comment - 4 Mar 2016

Just a note here because I couldn't workout detailed and reproducable test instructions yet to open an issue.
For a longer time now (3.4.x, several installations) I see frequently a similiar behavior after login but always just once as far as I remember. Filters "forget" their first settings after some actions in list views (without this PR) and fall back to first entry.
Just a "maybe somewhow related" to #9231 (comment)

avatar infograf768
infograf768 - comment - 4 Mar 2016

In the case here, some code was required (the changes just done i.e. adding JFactory::getApplication()->getUserState('com_menus.items.menutype') to be sure to redirect to the correct screen)

If you have experienced issues elsewhere, please create a new issue.
In the mean while, thanks for testing here (and find the issue ☺ ).
If OK for you now, please mark test as successful.

avatar bertmert bertmert - test_item - 4 Mar 2016 - Tested successfully
avatar bertmert
bertmert - comment - 4 Mar 2016

I have tested this item :white_check_mark: successfully on 5205083


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

avatar grhcj grhcj - test_item - 4 Mar 2016 - Tested successfully
avatar grhcj
grhcj - comment - 4 Mar 2016

I have tested this item :white_check_mark: successfully on 5205083


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

avatar infograf768 infograf768 - change - 4 Mar 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 9 Mar 2016

thanks for testing. rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

avatar joomla-cms-bot joomla-cms-bot - change - 9 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 10 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 12 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - change - 12 Apr 2016
Milestone Removed:
avatar rdeutz
rdeutz - comment - 12 Apr 2016

looks for me like a new feature, changing Milestone to 3.6.

avatar zero-24
zero-24 - comment - 12 Apr 2016

if there is the decision that this is a new feature can we have a New feature label here than? @rdeutz

avatar ggppdk ggppdk - test_item - 12 Apr 2016 - Tested successfully
avatar ggppdk
ggppdk - comment - 12 Apr 2016

I have tested this item :white_check_mark: successfully on 5205083


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

avatar MDXBilal12 MDXBilal12 - test_item - 19 Apr 2016 - Tested successfully
avatar MDXBilal12
MDXBilal12 - comment - 19 Apr 2016

I have tested this item :white_check_mark: successfully on 5205083


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

avatar brianteeman brianteeman - change - 19 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 19 Apr 2016
Category Administration UI/UX Administration Feature Request UI/UX
avatar brianteeman brianteeman - change - 19 Apr 2016
Labels
avatar brianteeman brianteeman - change - 27 Apr 2016
Labels
avatar brianteeman brianteeman - change - 27 Apr 2016
Category Administration UI/UX Feature Request Administration Feature Request Language & Strings UI/UX
avatar rdeutz
rdeutz - comment - 2 May 2016

@infograf768 cloud you please check the merge conflicts, thanks

avatar infograf768
infograf768 - comment - 2 May 2016

Hmm. I must have deleted my local instance of this branch.
Here is a new PR conflicts solved.
#10190

I close this one.

avatar infograf768 infograf768 - change - 2 May 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-05-02 10:41:18
Closed_By infograf768
avatar rdeutz rdeutz - close - 2 May 2016
avatar rdeutz rdeutz - close - 2 May 2016
avatar zero-24
zero-24 - comment - 2 May 2016

@brianteeman @rdeutz can you remove the RTC label and the milestone?

avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2016
Labels Removed: ?
avatar rdeutz rdeutz - change - 2 May 2016
Labels Removed: ? ?
avatar rdeutz rdeutz - change - 2 May 2016
Labels Removed: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2016
Labels Added: ?

Add a Comment

Login with GitHub to post a comment