User tests: Successful: Unsuccessful:
This PR to replace obsolete #8411
@brianteeman
@bertmert
@sural98
@andrepereiradasilva
To test on staging.
Only change vs #8411 is the Toolbar Title:
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
Easy | No | ⇒ | Yes |
Category | ⇒ | Administration UI/UX |
As most operations and simple structure comprehension in this manager imply selecting a specific menu, I think we should keep the Select Menu separate.
I have tested this item successfully on 0605b12
Thanks for testing. Bad luck this would be in 3.6.0 only :)
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
I have tested this item unsuccessfully on 0605b12
- BE > Menu item manager.
Expected:
Status | Ready to Commit | ⇒ | Pending |
@bertmert
I confirm the issue. Taking off RTC for now.
Labels |
Removed:
?
|
This PR has received new commits.
CC: @andrepereiradasilva, @bertmert, @richard67
I have already a solution for setdefault Home which I am now merging.
To solve the publishing state, I did not find any other solution than overriding legacy/controller/admin.php publish() method.
If someone has a better idea, please let me know.
This PR has received new commits.
CC: @andrepereiradasilva, @bertmert, @richard67
Now the publish() method is overriden. remains the Check-in one.
This PR has received new commits.
CC: @andrepereiradasilva, @bertmert, @richard67
Please test again all toolbar buttons and Status icons. Issues should be now solved.
This PR has received new commits.
CC: @andrepereiradasilva, @bertmert, @richard67
This PR has received new commits.
CC: @andrepereiradasilva, @bertmert, @richard67
Just a note here because I couldn't workout detailed and reproducable test instructions yet to open an issue.
For a longer time now (3.4.x, several installations) I see frequently a similiar behavior after login but always just once as far as I remember. Filters "forget" their first settings after some actions in list views (without this PR) and fall back to first entry.
Just a "maybe somewhow related" to #9231 (comment)
In the case here, some code was required (the changes just done i.e. adding JFactory::getApplication()->getUserState('com_menus.items.menutype')
to be sure to redirect to the correct screen)
If you have experienced issues elsewhere, please create a new issue.
In the mean while, thanks for testing here (and find the issue ☺ ).
If OK for you now, please mark test as successful.
I have tested this item successfully on 5205083
I have tested this item successfully on 5205083
Status | Pending | ⇒ | Ready to Commit |
thanks for testing. rtc
Labels |
Added:
?
|
Milestone |
Added: |
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Removed: |
looks for me like a new feature, changing Milestone to 3.6.
I have tested this item successfully on 5205083
I have tested this item successfully on 5205083
Labels |
Added:
?
|
Category | Administration UI/UX | ⇒ | Administration Feature Request UI/UX |
Labels |
Labels |
Category | Administration UI/UX Feature Request | ⇒ | Administration Feature Request Language & Strings UI/UX |
@infograf768 cloud you please check the merge conflicts, thanks
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-02 10:41:18 |
Closed_By | ⇒ | infograf768 |
@brianteeman @rdeutz can you remove the RTC label and the milestone?
Labels |
Removed:
?
|
Labels |
Removed:
?
?
|
Labels |
Removed:
?
?
|
Labels |
Added:
?
|
Labels |
Added:
?
|
I have tested this item successfully on 0605b12
Works fine.
I just have a consistency problem with this change.
In all other views, there is only one field (let's call it selector) that, is not inside the "Search filters": the client (or location). And this only exist in modules, cache and installed languages views.
That i know of, this is the only view that as a different selector: the menutype, but, if you have "- Select Menu -" option in theory is not a selector anymore as status, access, language and max levels are not. IMHO it turns itself into a search filter. And in that logic it should go inside search filters.
See, for instance, the example of the categories filter in articles view ...
PS: I know that this can be controversal. And don't want to hijack this PR with this, just leaving the thought here.
Marking as tested successfully as this PR works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.