[#9234] - Minor change in selector titles
- Closed
- 28 Feb 2016
- Medium
- Build: staging
- # 9234
- Diff
- andrepereiradasilva:minor-change-in-selector-titles
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
As discussed in #9227 this PR changes title in com_cache cache view, com_module, modules view and com_languagues installed view.
Testing Instructions
- Use latest staging
- Install this patch
- Check if the page title changes to "(Site)" or "(Administrator)" according to the selected client in the views described above.
Observations
I removed the recently added language variable because i think they are not needed as we have JADMINISTRATOR and JSITE.
If not please say so.
@brianteeman, @infograf768 please test.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Labels |
Added:
?
?
|
||
I have tested this item 
successfully on 45c6d2b
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9234.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-28 01:16:18 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
REGRESSION! Not B/C
The original strings must not be modified as the language packs for 3.5.0 may be used on pre-350 sites.
example:
-COM_LANGUAGES_VIEW_INSTALLED_TITLE="Languages: Installed"
+COM_LANGUAGES_VIEW_INSTALLED_TITLE="Languages: Installed (%s)"
On a pre-350 site the toolbar title will show:
Languages: Installed ()
Same for cache.
| Labels |
Removed:
?
|
||
I see no reason at all for this to be an issue - we do not support old
versions of joomla - if nothing else because they are vulnerable to being
hacked. If someone has an old version of joomla and installs a new language
file that should not be our problem - we want people to upgrade.
This is nothing to do with backwards compatibility
On 28 February 2016 at 07:09, infograf768 notifications@github.com wrote:
REGRESSION! Not B/C
The original strings must not be modified as the language packs for 3.5.0
may be used on pre-350 sites.
example:-COM_LANGUAGES_VIEW_INSTALLED_TITLE="Languages: Installed"
+COM_LANGUAGES_VIEW_INSTALLED_TITLE="Languages: Installed (%s)"On a pre-350 site the toolbar title will show:
Languages: Installed ()Same for cache.
—
Reply to this email directly or view it on GitHub
#9234 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
It is not B/C. The policy is to not modify older strings that can be used by older versions (3.4.8 is not so old that everybody will move to 3.5.0...).
It would be OK if the modification of the string value was typo/better english or better explanation of a tip, but in this case we introduce a new variable with parenthesis.
I have tested this item
successfully on 45c6d2b
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9234.