? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
22 Feb 2016

Summary of Changes

This PR adds JLayout searchtools to com_content articles modal view.
Also adds the status column, moves the category to below the article title and makes some minor visual changes to be more synchronized with the non modal view.

Before PR

before-pr

After PR

after-pr

Testing Instructions

  1. Use latest staging
  2. In the backend edit any article and press "+Article" button on the editor, how will see a modal window with the old filter. Note: you can also create a "Single article" menu item type and select the article there.
  3. Apply this patch
  4. Repeat 2. and you'll see the new searchtools
  5. Now test search, ordering, filter, etc. Also select an article. In other words, test if everything works fine.

That i know of, correct me if i'm wrong, this view is used in:
1. "+Article" button in any editor (frontend and backend) -> all articles
2. Menu item "Single Article", "Select" button -> all articles
3. When language associations are enabled. Article "Associations" tab -> articles filtered by language

All this views should be tested.

Observations

That i know of, this is the first searchtools implemented on a modal view, so suggestions and improvements are welcomed.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar andrepereiradasilva andrepereiradasilva - open - 22 Feb 2016
avatar andrepereiradasilva andrepereiradasilva - change - 22 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Feb 2016
Labels Added: ?
avatar RonakParmar
RonakParmar - comment - 23 Feb 2016

@andrepereiradasilva Thanks for the patch.
I have applied this path and works fine for me.
Here is my system information:

Joomla! Version: Joomla! 3.4.8 Stable [ Ember ] 24-December-2015 19:30 GMT
Joomla! Platform Version: Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
PHP Version: 5.4.45-3+deb.sury.org~precise+1
System Linux desktop 3.5.0-54-generic #81~precise1-Ubuntu SMP Tue Jul 15 04:02:22 UTC 2014 x86_64


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9195.

avatar RonakParmar RonakParmar - test_item - 23 Feb 2016 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 23 Feb 2016

I have tested this item :white_check_mark: successfully on b81e103


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9195.

avatar infograf768 infograf768 - test_item - 23 Feb 2016 - Tested unsuccessfully
avatar infograf768
infograf768 - comment - 23 Feb 2016

I have tested this item :red_circle: unsuccessfully on b81e103

Multilingual sites: This PR breaks forcedLanguage when articles associations are set as one can choose another language than the language it should be associated to. In that case the Select Language should not be proposed.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9195.

avatar andrepereiradasilva
andrepereiradasilva - comment - 23 Feb 2016

@infograf768 could you describe the steps you made to test so i can try to resolve the uissue you're referring?

avatar infograf768
infograf768 - comment - 23 Feb 2016

Multilingual site:
Edit an article in one language, go to associations tab
"Select" an article for a specific language: the modal opens.
Remark that only the articles tagged to this specific language are displayed and one CANNOT change language to display articles not tagged to the said lang.

screen shot 2016-02-23 at 12 17 12

I click on the Select button for Italian:
screen shot 2016-02-23 at 12 18 40

The code to NOT display the language dropdown depends on the filter.forcedLanguage setting.

avatar andrepereiradasilva
andrepereiradasilva - comment - 23 Feb 2016

ok, i see will check that later. thanks

That i know of, correct me if i'm wrong, this view is used in:
1. "+Article" button in any editor (frontend and backend) -> all articles
2. Menu item "Single Article", "Select" button -> all articles
3. When language associations are enabled. Article "Associations" tab -> articles filtered by language

avatar infograf768
infograf768 - comment - 23 Feb 2016

Yep.

avatar joomla-cms-bot
joomla-cms-bot - comment - 23 Feb 2016

This PR has received new commits.

CC: @infograf768, @RonakParmar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9195.

avatar joomla-cms-bot
joomla-cms-bot - comment - 23 Feb 2016

This PR has received new commits.

CC: @infograf768, @RonakParmar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9195.

avatar joomla-cms-bot
joomla-cms-bot - comment - 23 Feb 2016

This PR has received new commits.

CC: @infograf768, @RonakParmar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9195.

avatar andrepereiradasilva
andrepereiradasilva - comment - 23 Feb 2016

@infograf768 made some changes that i think resolves the issue you described.

The idea would be we could use this PR to replicate, in other words, with the necessary adaptations, implement searchtools on other modal views.

So IMHO this should be tested with time and with all possible scenarios (functionality in all views where it's used, B/C, security, etc).

avatar andrepereiradasilva andrepereiradasilva - change - 23 Feb 2016
The description was changed
9d3a288 23 Feb 2016 avatar andrepereiradasilva cs
avatar joomla-cms-bot
joomla-cms-bot - comment - 23 Feb 2016

This PR has received new commits.

CC: @infograf768, @RonakParmar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9195.

avatar infograf768
infograf768 - comment - 24 Feb 2016

This works great.

Comments:
I see no reason to take off filtering by Author or Tags or MAx Levels.

Is it also possible to reset the category field (i.e. in fact Clear) when Selecting an article for another language? Otherwise one has to clear each time when choosing an association for a different language.

Note: I had tested here another solution where searchtools filters were customised. But I had to specifically introduce the variable in filters.php
In fact, I think we should improve SearchTools by letting display or not specific fields, a bit similar to what is done for layout edit params.php
See https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/edit/params.php#L21-L23

avatar andrepereiradasilva
andrepereiradasilva - comment - 24 Feb 2016

Comments: I see no reason to take off filtering by Author or Tags or MAx Levels.

ok, will show them.

Is it also possible to reset the category field (i.e. in fact Clear) when Selecting an article for another language? Otherwise one has to clear each time when choosing an association for a different language.

ok. i see. if we use "+article" modal and them the language associations modal it populates the filter with previous selected filter. i think each forced language needs a exclusive state context.

Note: I had tested here another solution where searchtools filters were customised. But I had to specifically introduce the variable in filters.php
In fact, I think we should improve SearchTools by letting display or not specific fields, a bit similar to what is done for layout edit params.php
See https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/edit/params.php#L21-L23

Yes, i also see some changes that searchtools could be simplified (ex: not adding layout overrides just because of the client selector) and also add some more flexibility, but that if for a future PR IMHO.

avatar joomla-cms-bot
joomla-cms-bot - comment - 24 Feb 2016

This PR has received new commits.

CC: @infograf768, @RonakParmar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9195.

avatar joomla-cms-bot
joomla-cms-bot - comment - 24 Feb 2016

This PR has received new commits.

CC: @infograf768, @RonakParmar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9195.

avatar andrepereiradasilva
andrepereiradasilva - comment - 24 Feb 2016

@infograf768 can you check now?

BTW one thing i noticed: in the frontend edit, the status icons don't have colors.

"+Article" editor button in Frontend

image

"+Article" editor button in Backend

image

Update:
The difference is:

i can update the protostar less, but will it have any influence in other things? Can it be changed safely?

avatar infograf768
infograf768 - comment - 24 Feb 2016

This now works fine for me.
I would not touch at icomoon.less as you can see that protostar is never using coloured icons.
If you were, we would also have to change icon-cancel and possibly icon-save, etc.

avatar andrepereiradasilva
andrepereiradasilva - comment - 24 Feb 2016

ok sure.

avatar infograf768 infograf768 - test_item - 24 Feb 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 24 Feb 2016

I have tested this item :white_check_mark: successfully on 936494c

This works fine

remains to do Contacts and Newsfeeds (It looks like this last one has issues with forcedlanguage)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9195.

avatar andrepereiradasilva
andrepereiradasilva - comment - 24 Feb 2016

com_contact: #9198
com_newsfeeds: #9206
com_categories: #9208

and there are other modal layout lists that i think should follow the same logic: users and modules

A list of list views modal.php files:

Core:
/administrator/components/com_content/views/articles/tmpl/modal.php
/administrator/components/com_newsfeeds/views/newsfeeds/tmpl/modal.php
/administrator/components/com_categories/views/categories/tmpl/modal.php
/administrator/components/com_modules/views/modules/tmpl/modal.php
/administrator/components/com_modules/views/positions/tmpl/modal.php
/administrator/components/com_users/views/users/tmpl/modal.php
/administrator/components/com_contact/views/contacts/tmpl/modal.php

Hathor overrides:
/administrator/templates/hathor/html/com_newsfeeds/newsfeeds/modal.php
/administrator/templates/hathor/html/com_modules/positions/modal.php
/administrator/templates/hathor/html/com_users/users/modal.php
/administrator/templates/hathor/html/com_contact/contacts/modal.php
avatar infograf768
infograf768 - comment - 25 Feb 2016

As this series of patches contain the same change to the category field type, I suggest, before going further to get a milestone from maintainers.
@wilsonge ?

avatar joomlacorner
joomlacorner - comment - 26 Feb 2016

This works fine.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9195.

avatar joomlacorner joomlacorner - test_item - 26 Feb 2016 - Tested successfully
avatar joomlacorner
joomlacorner - comment - 26 Feb 2016

I have tested this item :white_check_mark: successfully on 936494c

This works fine


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9195.

avatar brianteeman brianteeman - change - 27 Feb 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 27 Feb 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9195.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 22 Mar 2016
Category UI/UX
avatar brianteeman brianteeman - change - 22 Mar 2016
Labels
avatar brianteeman brianteeman - change - 12 Apr 2016
Milestone Added:
avatar brianteeman brianteeman - change - 12 Apr 2016
Milestone Added:
avatar wilsonge wilsonge - reference | bd513a2 - 12 Apr 16
avatar wilsonge wilsonge - merge - 12 Apr 2016
avatar wilsonge wilsonge - close - 12 Apr 2016
avatar wilsonge wilsonge - change - 12 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-12 22:53:39
Closed_By wilsonge
avatar wilsonge wilsonge - close - 12 Apr 2016
avatar wilsonge wilsonge - merge - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 12 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment