User tests: Successful: Unsuccessful:
This PR adds JLayout searchtools to com_content articles modal view.
Also adds the status column, moves the category to below the article title and makes some minor visual changes to be more synchronized with the non modal view.
That i know of, correct me if i'm wrong, this view is used in:
1. "+Article" button in any editor (frontend and backend) -> all articles
2. Menu item "Single Article", "Select" button -> all articles
3. When language associations are enabled. Article "Associations" tab -> articles filtered by language
All this views should be tested.
That i know of, this is the first searchtools implemented on a modal view, so suggestions and improvements are welcomed.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
I have tested this item successfully on b81e103
I have tested this item unsuccessfully on b81e103
Multilingual sites: This PR breaks forcedLanguage when articles associations are set as one can choose another language than the language it should be associated to. In that case the Select Language should not be proposed.
@infograf768 could you describe the steps you made to test so i can try to resolve the uissue you're referring?
Multilingual site:
Edit an article in one language, go to associations tab
"Select" an article for a specific language: the modal opens.
Remark that only the articles tagged to this specific language are displayed and one CANNOT change language to display articles not tagged to the said lang.
I click on the Select button for Italian:
The code to NOT display the language dropdown depends on the filter.forcedLanguage setting.
ok, i see will check that later. thanks
That i know of, correct me if i'm wrong, this view is used in:
1. "+Article" button in any editor (frontend and backend) -> all articles
2. Menu item "Single Article", "Select" button -> all articles
3. When language associations are enabled. Article "Associations" tab -> articles filtered by language
Yep.
This PR has received new commits.
CC: @infograf768, @RonakParmar
This PR has received new commits.
CC: @infograf768, @RonakParmar
This PR has received new commits.
CC: @infograf768, @RonakParmar
@infograf768 made some changes that i think resolves the issue you described.
The idea would be we could use this PR to replicate, in other words, with the necessary adaptations, implement searchtools on other modal views.
So IMHO this should be tested with time and with all possible scenarios (functionality in all views where it's used, B/C, security, etc).
This PR has received new commits.
CC: @infograf768, @RonakParmar
This works great.
Comments:
I see no reason to take off filtering by Author or Tags or MAx Levels.
Is it also possible to reset the category field (i.e. in fact Clear) when Selecting an article for another language? Otherwise one has to clear each time when choosing an association for a different language.
Note: I had tested here another solution where searchtools filters were customised. But I had to specifically introduce the variable in filters.php
In fact, I think we should improve SearchTools by letting display or not specific fields, a bit similar to what is done for layout edit params.php
See https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/edit/params.php#L21-L23
Comments: I see no reason to take off filtering by Author or Tags or MAx Levels.
ok, will show them.
Is it also possible to reset the category field (i.e. in fact Clear) when Selecting an article for another language? Otherwise one has to clear each time when choosing an association for a different language.
ok. i see. if we use "+article" modal and them the language associations modal it populates the filter with previous selected filter. i think each forced language needs a exclusive state context.
Note: I had tested here another solution where searchtools filters were customised. But I had to specifically introduce the variable in filters.php
In fact, I think we should improve SearchTools by letting display or not specific fields, a bit similar to what is done for layout edit params.php
See https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/edit/params.php#L21-L23
Yes, i also see some changes that searchtools could be simplified (ex: not adding layout overrides just because of the client selector) and also add some more flexibility, but that if for a future PR IMHO.
This PR has received new commits.
CC: @infograf768, @RonakParmar
This PR has received new commits.
CC: @infograf768, @RonakParmar
@infograf768 can you check now?
BTW one thing i noticed: in the frontend edit, the status icons don't have colors.
Update:
The difference is:
i can update the protostar less, but will it have any influence in other things? Can it be changed safely?
This now works fine for me.
I would not touch at icomoon.less as you can see that protostar is never using coloured icons.
If you were, we would also have to change icon-cancel and possibly icon-save, etc.
ok sure.
I have tested this item successfully on 936494c
This works fine
remains to do Contacts and Newsfeeds (It looks like this last one has issues with forcedlanguage)
com_contact: #9198
com_newsfeeds: #9206
com_categories: #9208
and there are other modal layout lists that i think should follow the same logic: users and modules
A list of list views modal.php files:
Core:
/administrator/components/com_content/views/articles/tmpl/modal.php
/administrator/components/com_newsfeeds/views/newsfeeds/tmpl/modal.php
/administrator/components/com_categories/views/categories/tmpl/modal.php
/administrator/components/com_modules/views/modules/tmpl/modal.php
/administrator/components/com_modules/views/positions/tmpl/modal.php
/administrator/components/com_users/views/users/tmpl/modal.php
/administrator/components/com_contact/views/contacts/tmpl/modal.php
Hathor overrides:
/administrator/templates/hathor/html/com_newsfeeds/newsfeeds/modal.php
/administrator/templates/hathor/html/com_modules/positions/modal.php
/administrator/templates/hathor/html/com_users/users/modal.php
/administrator/templates/hathor/html/com_contact/contacts/modal.php
This works fine.
I have tested this item successfully on 936494c
This works fine
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
Category | ⇒ | UI/UX |
Labels |
Milestone |
Added: |
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-12 22:53:39 |
Closed_By | ⇒ | wilsonge |
Labels |
Removed:
?
|
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
@andrepereiradasilva Thanks for the patch.
I have applied this path and works fine for me.
Here is my system information:
Joomla! Version: Joomla! 3.4.8 Stable [ Ember ] 24-December-2015 19:30 GMT
Joomla! Platform Version: Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
PHP Version: 5.4.45-3+deb.sury.org~precise+1
System Linux desktop 3.5.0-54-generic #81~precise1-Ubuntu SMP Tue Jul 15 04:02:22 UTC 2014 x86_64
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9195.