[#9196] - Fix #9129 User - Profile plugin erases data when field is disabled in frontend
- Closed
- 24 Feb 2016
- Medium
- Build: staging
- # 9196
- Diff
- bertmert:patch-56
- Pending Human Test Results: 0 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9129.
Testing Instructions
Enable the user - profile plugin.
Within the plugin, under "User profile fields for registration and administrator user forms" select optional for the "Favorite Book" field.
under "User profile fields for profile edit form", select "disable" for the "Favorite Book" field.
Create a user in the administrator panel and fill in the "Favorite Book" field.
Go to the front-end, select "edit your profile" and hit submit.
Before patch:
If you go to the administrator panel the "Favorite Book" field will be empty.
After patch:
If you go to the administrator panel the "Favorite Book" field will NOT be empty.
Please test this PR in-depth with other fields and setting scenarios, too!
Lines 266 to 274 are not related to the issue.
Votes
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Rel_Number | 0 | ⇒ | 9129 |
| Relation Type | ⇒ | Pull Request for |
This PR has received new commits.
CC: @RonakParmar
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9196.
I have tested this PR for "Favourite Book:" field for now and works fine for me.
I personally wouldn't accept this test as successful ;-)
Please test more detailled with other fields, too (textarea, calendar). I hadn't the time yet.
| Category | ⇒ | Plugins |
As this just makes the fields hidden, doesn't that mean that by editing the fields in dev tools you can edit them despite not having the permissions?
I have tested this item 
unsuccessfully on befc16e
@wilsonge is correct hiding the field doesnt stop me from editing it
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9196.
... and if you were using the field for confidential information you didnt want the user to see then its definitely a no no
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9196.
So, reopen the issue. Will close this one.
My personal view is that profile data fields like this aren't the correct place for confidential datas at all. Use user notes instead! Or connect users with com_contact!
On the other hand these are datas that are shown and filled by users during registration. That's why they're called "My Profile" datas.
The only way to prevent them from deleting is to show them users or hide them or to "cache" them in plugin for later saving before the form fields are removed. Or add an additional database query in onUserAfterSave().
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-24 00:46:49 |
| Closed_By | ⇒ | bertmert |
ITs not just about being able to see the contents of a hidden field but that you can change it as well. Thanks for trying though - I have reopened the original Issue report
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9196.
ITs not just about being able to see the contents of a hidden field but that you can change it as well. Thanks for trying though - I have reopened the original Issue report
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9196.
I have tested this item
successfully on 6ca6cca
I have tested this PR for "Favourite Book:" field for now and works fine for me.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9196.