Feeling Lucky
?
?
[#9194] - Tests JLogEntry and the difference of one second
- Closed
- 24 Feb 2016
- Medium
- Build: staging
- # 9194
- Diff
- csthomas:teststupidfail
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
No issue.
Summary of Changes
From time to time tests fails but everything is OK.
The problem is in /tests/unit/suites/libraries/joomla/log/JLogEntryTest on line 28:
$tmp = new JLogEntry('Lorem ipsum dolor sit amet');
$date = JFactory::getDate('now');
When $tmp->date is "2016-02-22 19:00:01"
and $date is one second later "2016-02-22 19:00:02" then assertion fails.
Testing Instructions
Random fails.
I had situation when my pull request did not pass one php version tests.
When I used commit --amend and pushed force again then all tests passed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
csthomas
- comment
- 24 Feb 2016
Ok, assertEquals
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-24 09:22:08 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 24 Feb 2016
Merged - thanks!
| Milestone |
Added: |
||
Rather than use use the
$deltaparameter ofassertEqualsI think rather than this (https://github.com/sebastianbergmann/phpunit/blob/4.8/src/Framework/Assert.php#L503-L514)