[#9193] - Regression: joomla update notification
- Closed
- 23 Feb 2016
- Medium
- Build: staging
- # 9193
- Diff
- andrepereiradasilva:patch-2
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR solves a regression where when you activate the update plugin you receive e-mail with updates for non joomla core extensions.
The change this PR does is to remove a line added before, and with that solving the problem.
Testing Instructions
- Use latest staging.
- Configure joomla to send mails.
- Install some extension with updates (i used com_localize 4.0.13-dev). https://github.com/joomla-projects/com_localise/releases/download/4.0.13-dev/com_localise-4.0.13-dev.zip
- Enable update notification system plugin.
- Logout your admin session.
- Refresh the page several times in the admin login view.
- You should receive a mail there is a joomla update when there isn't. If not you can force it on next refresh by changing this line (https://github.com/joomla/joomla-cms/blob/staging/plugins/system/updatenotification/updatenotification.php#L49) with
$last = 0; - Apply patch.
- Logout and repeat the same process. Check you don't receive e-mails update e-mails now.
@infograf768 This is similar with the one you have before. Can you test?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
I have tested this item 
successfully on cc41c8a
I could reproduce and this solves it. Quite important. @wilsonge
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9193.
I have tested this item successfully on cc41c8a
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9193.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-23 11:30:32 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
| Labels |
Removed:
?
|
||
@nikosdion can you just confirm this please (just in case)
By removing that line you make it impossible for the update model to only check for updates for a specific extension. I am not sure where / if this is used in our code but I'm pretty sure this feature wasn't added for no reason. Therefore I'm afraid that you are introducing a b/c break.
OK So can we find a fix to stop the extra emails being sent?
@nikosdion it was me that introduced that line by mistake. This PR is to correct my mistake.
Ah, fair enough.
@andrepereiradasilva
Could you contact me on skype : infograf768