Sorry typing this from my phone so can't check but please make sure you can
still switch between site and admin languages from a mobile device. You
can't for modules and this looks like it "might" have the same problem.
On 10 Feb 2016 11:44 pm, "andrepereiradasilva" notifications@github.com
wrote:

Description

With the change from #9101
#9101 doesn't make much sense
for the languages submenu to have two entries for Installed languages.

This PR, an addition to #9101
#9101, merges them in one
submenu option and also adds a submenu in the global admin menu (like
exists for extensions).

Please note there are changes in this PR code that are from #9101
#9101 and not related to the
changes done. They are there do avoid conflicts.
This should only be test after PR #9101
#9101 is applied.
After PR

[image: image]
https://cloud.githubusercontent.com/assets/9630530/12965643/ab15deea-d04f-11e5-8273-73ab7dbd8d55.png

[image: image]
https://cloud.githubusercontent.com/assets/9630530/12965626/8a2973fe-d04f-11e5-943b-bbfb7e25fbd2.png
How to test

1. Install latest joomla staging
2. Apply PR #9101 #9101 and then this PR
3. Check lanague submenu is working properly

---

You can view, comment on, or merge this pull request online at:

#9102
Commit Summary

• com_languages submenu changes

File Changes

• M administrator/components/com_languages/views/installed/view.html.php https://github.com/joomla/joomla-cms/pull/9102/files#diff-0 (25)
• M administrator/language/en-GB/en-GB.com_languages.ini https://github.com/joomla/joomla-cms/pull/9102/files#diff-1 (19)
• M administrator/language/en-GB/en-GB.mod_menu.ini https://github.com/joomla/joomla-cms/pull/9102/files#diff-2 (3)
• M administrator/modules/mod_menu/tmpl/default_enabled.php https://github.com/joomla/joomla-cms/pull/9102/files#diff-3 (7)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/9102.patch
• https://github.com/joomla/joomla-cms/pull/9102.diff

—
Reply to this email directly or view it on GitHub
#9102.

good point, will check that

Update: You can't. I will do the changes needed in #9101 (the problem is there)

@brianteeman done 270add5

Thanks
On 10 Feb 2016 11:59 pm, "andrepereiradasilva" notifications@github.com
wrote:

@brianteeman https://github.com/brianteeman done 270add5
270add5

—
Reply to this email directly or view it on GitHub
#9102 (comment).

For reference on the modules see #9031
On 11 Feb 2016 12:03 am, "Brian Teeman" brian@teeman.net wrote:

Thanks
On 10 Feb 2016 11:59 pm, "andrepereiradasilva" notifications@github.com
wrote:

@brianteeman https://github.com/brianteeman done 270add5
270add5

—
Reply to this email directly or view it on GitHub
#9102 (comment).

I have tested this item successfully on 19ec4c4

I have tested this item unsuccessfully on 19ec4c4

Tried to install PR from #9101 first as advised, but then I couldn't install this PR as I got an error saying it conflicts with PR #9101.
So I just installed this PR #9102 , which shows the pop out menu for the language sub menus, but clicking on any of the links produces a 500 Error "JForm::getInstance could not load file"
Tested with J3.5 beta2

@sandstorm871 because of the way that patchtester component works it wont be possible to do that. I am resetting your test result to untested

Yes, you have to merge these 2 PRs manually. But then everything works.

Just apply the patch for PR #9101, then download the changed files from PR #9102 and manually drop then into your installation (e.g. via ftp), then everything should work well.

To be more precise: For those files from PR #9102 which have merge conflicts with PR #9101, replace the file from PR #9101 by the one from PR #9102.

@richard67 Thanks, Just testing that now :)

At the chance of making myself look daft (Its not hard) , How do I then download the changed files from PR #9102

@sandstorm871 After having applied PR #9101, you go to PR #9102 on GitHub, list of changed files, and then for each of these 5 files:

1. Open the changed file by clicking the "View" button.
2. Then in the open file view click the "Raw" button.
3. Then use your browser's "Save as" function to save the file within the Joomla installation which you use for testing, into the same subdirectory as shown within the path in the list of changed files of the PR on GitHub.

If your test site is not on your local PC, save the files locally and then copy them with ftp or so up to your host.

I hope this information helps.

Ah OK, I'm not too daft then. That's how I was doing it.
I just thought I may have been missing a button somewhere to download, all the modified files :)

This PR has received new commits.

CC: @richard67, @sandstorm871

conflicts fixed. Test instructions now simplified.

@infograf768, could you also test that this brings no issue to your latest changes?

I have tested this item successfully on 6e188d5

I have tested this item successfully on 6e188d5

RTC

No problem here. All fine.

mantainers don't merge this. A way to choose the client in hathor is needed too.
I will check when i have time.

This PR has received new commits.

CC: @brianteeman, @richard67, @sandstorm871

This PR has received new commits.

CC: @brianteeman, @richard67, @sandstorm871

ok, now we can also choose the client in hathor

AAAAAHHH COMMENTED WRONG PR!!! Ignore previous comment from me, I delete it in Github now but it still may be shown onthe issue tracker for a while.

I have tested this item successfully on 5c4ce03

Works as with my previous test for Isis plus now for Hathor, too (new dropdown plus submitt button).

Negative here. Patch does not apply. It has conflict.
error: patch failed: administrator/components/com_languages/views/installed/view.html.php:18
error: administrator/components/com_languages/views/installed/view.html.php: patch does not apply
error: patch failed: administrator/language/en-GB/en-GB.com_languages.ini:46
error: administrator/language/en-GB/en-GB.com_languages.ini: patch does not apply
error: patch failed: administrator/components/com_languages/helpers/languages.php:23
error: administrator/components/com_languages/helpers/languages.php: patch does not apply
error: patch failed: administrator/templates/hathor/html/com_languages/installed/default.php:14
error: administrator/templates/hathor/html/com_languages/installed/default.php: patch does not apply
error: patch failed: administrator/templates/hathor/html/com_languages/installed/default.php:33
error: administrator/templates/hathor/html/com_languages/installed/default.php: patch does not apply

@infograf768 thats strange - github reports that there are no conflicts

I also get the conflict (for administrator/templates/hathor/html/com_languages/installed/default.php) when using eclipse.

Also here all was fine. Used staging with state as of yesterday afternoon, applied the patch and all was fine. Since yesterday afternoon was no commit on staging for the files treated by this PR.

SInce then was merged: #9190 which modified hathor

@infograf768 Ahhhhhhh ... you are right, and I am blind!

So either you change your nick name into "eagleEye768", or I change mine into "blindMole67"

But why the hell it is not shown on GitHub for the PR that there might be conflicts?

hum ... strange i will check that later.

Because if the file modifications are exactly the same then you can't apply the patch/diff but you can merge (as the lines are the same)

This PR has received new commits.

CC: @brianteeman, @richard67, @sandstorm871

should be ok for tests now.

It works, but I am not sure I like the sidebar containing only Installed.
It was much easier to see which client was displayed imho with:

Another solution would be to use

if ($this->state->get('client_id', 0) == 1)
        {
            JToolbarHelper::title(JText::_('COM_LANGUAGES_VIEW_INSTALLED_ADMIN_TITLE'), 'comments-2 langmanager');
        }
        else
        {
            JToolbarHelper::title(JText::_('COM_LANGUAGES_VIEW_INSTALLED_SITE_TITLE'), 'comments-2 langmanager');
        }

with the new strings:

COM_LANGUAGES_VIEW_INSTALLED_ADMIN_TITLE="Languages: Installed - Administrator"
COM_LANGUAGES_VIEW_INSTALLED_SITE_TITLE="Languages: Installed - Site"

to get in the toolbar title:

and

This would be consistent with the proposed PR here for Modules:
#9218
Please also test that one.

This PR has received new commits.

CC: @brianteeman, @richard67, @sandstorm871

This PR has received new commits.

CC: @brianteeman, @richard67, @sandstorm871

ok title now changes, please test.

I have tested this item successfully on aabe015

I have tested this item successfully on aabe015

Not sure we absolutely need here (int) and ===, but as it creates no issue. Works fine for me.

@andrepereiradasilva Sorry, I could not help with testing, have no usable test system right now, all messed up by failed utf8mb4 tests. Good that Brian and JM already have tested, thanks to both.

@richard67 i know you are with another task now ;)

@wilsonge this can go in imho. thanks.