? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
10 Feb 2016

Description

This PR adds, for consistency, as it exists in so many other views in the backoffice, the search tools (filte, order, etc) to com_languages installed view.

Other small code changes/improvements where made.

Please notice that now, since the client filter is incorporated in the "installed" view (just like in modules view), the two options in the left bar for this doesn't make much sense.
I will make another PR to propose a change to that.

Before PR

com_languages-installed-beforepr

After PR

image

How to test

  1. Install latest staging and apply this patch
  2. Go to Extensions -> Languages -> Installed - Site and Installed - Administrator
  3. Check if everything is working fine.
avatar andrepereiradasilva andrepereiradasilva - open - 10 Feb 2016
avatar andrepereiradasilva andrepereiradasilva - change - 10 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2016
Labels Added: ? ?
15c43b9 10 Feb 2016 avatar andrepereiradasilva cs
avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Feb 2016

travis? where are you?

avatar richard67 richard67 - test_item - 10 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 10 Feb 2016

I have tested this item :white_check_mark: successfully on 15c43b9


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar joomla-cms-bot
joomla-cms-bot - comment - 10 Feb 2016

This PR has received new commits.

CC: @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Feb 2016

Client filter works now on mobile too.

image

avatar infograf768
infograf768 - comment - 11 Feb 2016

@andrepereiradasilva
I am not in favor of changing "Language" to "Native Title". This is reserved to the content languages.
We ask TTs to always use English first in the tag
For example: <name>Persian</name>
<name>French (FR)</name>

Also, as you are there, please add the nowrap class here

                    <th class="nowrap">
                        <?php echo JHtml::_('searchtools.sort', 'COM_LANGUAGES_HEADING_LANG_TAG', 'language', $listDirn, $listOrder); ?>
                    </th>
avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Feb 2016

Ups, that was not intentional.
Will correct later.

For UX and coherence should be the same as "Install Languages" right?
Picture:
image

avatar infograf768
infograf768 - comment - 11 Feb 2016

For the heading only, yes. (once you correct the installer to change Language Code to Language Tag)

The rows in the Installer language come from http://update.joomla.org/language/translationlist_3.xml where the last _xx-XX is taken off and underscore are changed to spaces (example Arabic Unitag)

avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Feb 2016

@infograf768 ok will check later

BTW, not to do with this PR and i'm not expert on how the languages show be named, but IMHO shouldn't the "name" of the language in the XML files have some kind of normalization?

I mean, for instance, "English" "name" is 3 times in that XML for different languages ... en-CA, en-AU and en-US, shouldn't it be something like this:

  • "English (Canada)" or "Canadian English"
  • "English (United States)" or "American English"
  • "English (Australia)" or "Australian English"

Another example is "FrenchCA" ;). Why not "French (Canada)" or "Canadian French"?

avatar infograf768
infograf768 - comment - 11 Feb 2016

concerning the names of the languages: as i said,they depend on the project name on jomlacode. I will check if it is BC to change them.

avatar joomla-cms-bot
joomla-cms-bot - comment - 11 Feb 2016

This PR has received new commits.

CC: @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Feb 2016

@richard67 @infograf768 can you test now?

Latest preview:
image

avatar richard67 richard67 - test_item - 11 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 11 Feb 2016

I have tested this item :white_check_mark: successfully on 9b2132c


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Feb 2016

This PR has received new commits.

CC: @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Feb 2016

@richard67 sorry for that, but i decided to add some aditional checks:

Now on client change resets the search box, ordering and limit.
Also only allow client_id parameter to be 0 or 1 (even if another value is send by POST or GET).

avatar infograf768
infograf768 - comment - 12 Feb 2016

@andrepereiradasilva
As the Version is displayed when reducing the window, you should take off hidden-phone from the heading here:

                    <th class="nowrap center hidden-phone">
                        <?php echo JHtml::_('searchtools.sort', 'COM_LANGUAGES_HEADING_VERSION', 'version', $listDirn, $listOrder); ?>
                    </th>
avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Feb 2016

Yes you're right. Will change it later.

avatar richard67
richard67 - comment - 12 Feb 2016

@andrepereiradasilva I'll wait for these changes before testing again.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Feb 2016

of course.

avatar sandstorm871
sandstorm871 - comment - 12 Feb 2016

screen shot 2016-02-12 at 07 39 38

Testing this, I notice that when in XS size, switching between admin/site languages, the dropdown field for administrator is not displaying correctly.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar infograf768
infograf768 - comment - 13 Feb 2016

That one is easy to solve.
Just introduce a min-width: 220px; in the new layout file

ROOT/administrator/components/com_languages/layouts/joomla/searchtools/default.php

avatar joomla-cms-bot
joomla-cms-bot - comment - 13 Feb 2016

This PR has received new commits.

CC: @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Feb 2016

i think it's all done now. Please retest.
xs size preview:
image

avatar richard67 richard67 - test_item - 13 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 13 Feb 2016

I have tested this item :white_check_mark: successfully on c0083aa

Success. XS mobile view is OK now, too.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar sandstorm871 sandstorm871 - test_item - 13 Feb 2016 - Tested successfully
avatar sandstorm871
sandstorm871 - comment - 13 Feb 2016

I have tested this item :white_check_mark: successfully on c0083aa


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar infograf768 infograf768 - change - 14 Feb 2016
Category UI/UX
avatar infograf768
infograf768 - comment - 14 Feb 2016

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar infograf768 infograf768 - change - 14 Feb 2016
Title
com_languages installer view, implement searchtools and ordering
com_languages installed view, implement searchtools and ordering
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2016
Title
com_languages installer view, implement searchtools and ordering
com_languages installed view, implement searchtools and ordering
avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Feb 2016

@infograf768 i think you forgot the "RTC" label in this one.

avatar brianteeman brianteeman - change - 15 Feb 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 15 Feb 2016

Thanks for testing - setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Feb 2016
Labels Added: ?
avatar joomla-cms-bot
joomla-cms-bot - comment - 15 Feb 2016

This PR has received new commits.

CC: @richard67, @sandstorm871


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar richard67 richard67 - test_item - 15 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 15 Feb 2016

I have tested this item :white_check_mark: successfully on 825d326


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar joomla-cms-bot
joomla-cms-bot - comment - 15 Feb 2016

This PR has received new commits.

CC: @richard67, @sandstorm871


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Feb 2016

@richard67 @sandstorm871 please don't test. it seems that is a problem with my branch.
When ok i will say so. Thanks.

Anyway the goal of the change is just to resolve conflicts in a language variable file after #9099 merge.

avatar richard67
richard67 - comment - 15 Feb 2016
avatar joomla-cms-bot
joomla-cms-bot - comment - 15 Feb 2016

This PR has received new commits.

CC: @richard67, @sandstorm871


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar joomla-cms-bot
joomla-cms-bot - comment - 15 Feb 2016

This PR has received new commits.

CC: @richard67, @sandstorm871


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar joomla-cms-bot
joomla-cms-bot - comment - 15 Feb 2016

This PR has received new commits.

CC: @richard67, @sandstorm871


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar infograf768 infograf768 - change - 16 Feb 2016
Status Ready to Commit Pending
avatar infograf768
infograf768 - comment - 16 Feb 2016

Setting back to pending until new tests.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Feb 2016
Labels Removed: ?
avatar richard67
richard67 - comment - 16 Feb 2016

@andrepereiradasilva Is this ready for new tests now? Or shall we wait for further commits?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Feb 2016

sorry, yes it's ready. I messed up my branch yesterday, but it's solved now.

avatar richard67
richard67 - comment - 16 Feb 2016

Better a messed up branch than a messed up brunch :smile: (I like games with words)

I'll test it soon.

avatar richard67
richard67 - comment - 16 Feb 2016

@andrepereiradasilva I have a problem but wanna ask you if you can replicate this before I mark my test result as negative.

I have 3 languages installed: The standard English, then German, then Russian.

I ordered the installed languages in a way (admin or site does not matter) that English was on top, and then entered "English" in the search box.

Result: Beside the English language also the German was found, but it does nowhere contain the text "english".

See following screenshot:

screen shot 2016-02-16 at 04 29 57

The russian language is not shown within the results, which is OK.

When I do a search for "German", it only finds "German" => OK.

Any idea why this can happen?

Maybe it is because English was on top of the list? Or because English is a kind of default?

Maybe a bug in the search tools so not related to your PR?

Let me know if you have an idea what it is and if it could be related to your PR or not, so I can mark my test result.

Everything else was working as desired.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Feb 2016

i will check later. thanks for all your testing.

Update:
I know now what happened.
Check \language\de-DE\de-DE.xml, there is "English" word in the language description.
Later, will remove the search in the description (this line: https://github.com/joomla/joomla-cms/pull/9101/files#diff-035308e44e8922df4664d309fbf977faR283).

avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Feb 2016

This PR has received new commits.

CC: @richard67, @sandstorm871


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar richard67 richard67 - test_item - 16 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 16 Feb 2016

I have tested this item :white_check_mark: successfully on 7ae2036

Works as well as with the last test plus the search does not go through the package descriptions.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar sandstorm871 sandstorm871 - test_item - 16 Feb 2016 - Tested successfully
avatar sandstorm871
sandstorm871 - comment - 16 Feb 2016

I have tested this item :white_check_mark: successfully on 7ae2036


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar brianteeman brianteeman - change - 17 Feb 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 17 Feb 2016

RTC thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9101.

avatar joomla-cms-bot joomla-cms-bot - change - 17 Feb 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 19 Feb 2016
Milestone Added:
avatar wilsonge
wilsonge - comment - 19 Feb 2016

Merged - thanks!

avatar wilsonge wilsonge - change - 19 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-19 01:19:20
Closed_By wilsonge
avatar wilsonge wilsonge - close - 19 Feb 2016
avatar wilsonge wilsonge - reference | f464382 - 19 Feb 16
avatar wilsonge
wilsonge - comment - 19 Feb 2016

Oops - missed some of the files first commit - the missing ones are added here: f464382

avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2016
Labels Removed: ?
avatar infograf768
infograf768 - comment - 19 Feb 2016

Urgent, this broke 2 merged PR
#9159

Add a Comment

Login with GitHub to post a comment