User tests: Successful: Unsuccessful:
This PR adds, for consistency, as it exists in so many other views in the backoffice, the search tools (filte, order, etc) to com_languages installed view.
Other small code changes/improvements where made.
Please notice that now, since the client filter is incorporated in the "installed" view (just like in modules view), the two options in the left bar for this doesn't make much sense.
I will make another PR to propose a change to that.
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
I have tested this item successfully on 15c43b9
This PR has received new commits.
CC: @richard67
@andrepereiradasilva
I am not in favor of changing "Language" to "Native Title". This is reserved to the content languages.
We ask TTs to always use English first in the tag
For example: <name>Persian</name>
<name>French (FR)</name>
Also, as you are there, please add the nowrap class here
<th class="nowrap">
<?php echo JHtml::_('searchtools.sort', 'COM_LANGUAGES_HEADING_LANG_TAG', 'language', $listDirn, $listOrder); ?>
</th>
For the heading only, yes. (once you correct the installer to change Language Code to Language Tag)
The rows in the Installer language come from http://update.joomla.org/language/translationlist_3.xml where the last _xx-XX is taken off and underscore are changed to spaces (example Arabic Unitag)
@infograf768 ok will check later
BTW, not to do with this PR and i'm not expert on how the languages show be named, but IMHO shouldn't the "name" of the language in the XML files have some kind of normalization?
I mean, for instance, "English" "name" is 3 times in that XML for different languages ... en-CA, en-AU and en-US, shouldn't it be something like this:
Another example is "FrenchCA" ;). Why not "French (Canada)" or "Canadian French"?
concerning the names of the languages: as i said,they depend on the project name on jomlacode. I will check if it is BC to change them.
This PR has received new commits.
CC: @richard67
@richard67 @infograf768 can you test now?
I have tested this item successfully on 9b2132c
This PR has received new commits.
CC: @richard67
@richard67 sorry for that, but i decided to add some aditional checks:
Now on client change resets the search box, ordering and limit.
Also only allow client_id parameter to be 0 or 1 (even if another value is send by POST or GET).
@andrepereiradasilva
As the Version is displayed when reducing the window, you should take off hidden-phone from the heading here:
<th class="nowrap center hidden-phone">
<?php echo JHtml::_('searchtools.sort', 'COM_LANGUAGES_HEADING_VERSION', 'version', $listDirn, $listOrder); ?>
</th>
Yes you're right. Will change it later.
@andrepereiradasilva I'll wait for these changes before testing again.
of course.
Testing this, I notice that when in XS size, switching between admin/site languages, the dropdown field for administrator is not displaying correctly.
That one is easy to solve.
Just introduce a min-width: 220px; in the new layout file
ROOT/administrator/components/com_languages/layouts/joomla/searchtools/default.php
This PR has received new commits.
CC: @richard67
I have tested this item successfully on c0083aa
Success. XS mobile view is OK now, too.
I have tested this item successfully on c0083aa
Category | ⇒ | UI/UX |
RTC. Thanks.
Title |
|
Title |
|
@infograf768 i think you forgot the "RTC" label in this one.
Status | Pending | ⇒ | Ready to Commit |
Labels |
Thanks for testing - setting RTC
Labels |
Added:
?
|
This PR has received new commits.
CC: @richard67, @sandstorm871
I have tested this item successfully on 825d326
This PR has received new commits.
CC: @richard67, @sandstorm871
@richard67 @sandstorm871 please don't test. it seems that is a problem with my branch.
When ok i will say so. Thanks.
Anyway the goal of the change is just to resolve conflicts in a language variable file after #9099 merge.
This PR has received new commits.
CC: @richard67, @sandstorm871
This PR has received new commits.
CC: @richard67, @sandstorm871
This PR has received new commits.
CC: @richard67, @sandstorm871
Status | Ready to Commit | ⇒ | Pending |
Setting back to pending until new tests.
Labels |
Removed:
?
|
@andrepereiradasilva Is this ready for new tests now? Or shall we wait for further commits?
sorry, yes it's ready. I messed up my branch yesterday, but it's solved now.
Better a messed up branch than a messed up brunch (I like games with words)
I'll test it soon.
@andrepereiradasilva I have a problem but wanna ask you if you can replicate this before I mark my test result as negative.
I have 3 languages installed: The standard English, then German, then Russian.
I ordered the installed languages in a way (admin or site does not matter) that English was on top, and then entered "English" in the search box.
Result: Beside the English language also the German was found, but it does nowhere contain the text "english".
See following screenshot:
The russian language is not shown within the results, which is OK.
When I do a search for "German", it only finds "German" => OK.
Any idea why this can happen?
Maybe it is because English was on top of the list? Or because English is a kind of default?
Maybe a bug in the search tools so not related to your PR?
Let me know if you have an idea what it is and if it could be related to your PR or not, so I can mark my test result.
Everything else was working as desired.
i will check later. thanks for all your testing.
Update:
I know now what happened.
Check \language\de-DE\de-DE.xml
, there is "English" word in the language description.
Later, will remove the search in the description (this line: https://github.com/joomla/joomla-cms/pull/9101/files#diff-035308e44e8922df4664d309fbf977faR283).
This PR has received new commits.
CC: @richard67, @sandstorm871
I have tested this item successfully on 7ae2036
Works as well as with the last test plus the search does not go through the package descriptions.
I have tested this item successfully on 7ae2036
Status | Pending | ⇒ | Ready to Commit |
Labels |
RTC thanks
Labels |
Added:
?
|
Milestone |
Added: |
Merged - thanks!
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-19 01:19:20 |
Closed_By | ⇒ | wilsonge |
Labels |
Removed:
?
|
travis? where are you?