[#9103] - Correcting Plugins Select Status
- Closed
- 13 Feb 2016
- Medium
- Build: staging
- # 9103
- Diff
- infograf768:pluginfilters
- Success Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR corrects the Select Status list for plugins.
Trashed and Archived should not be displayed.
Also as we use Disabled and Enabled for plugins, this PR adds a new field "plugin_status" with the correct String constants.
After patching you should get:
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
@infograf768 "All" is not needed.
Why not?
On 11 February 2016 at 09:49, andrepereiradasilva notifications@github.com
wrote:
@infograf768 https://github.com/infograf768 "All" is not needed.
—
Reply to this email directly or view it on GitHub
#9103 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Because "-Select Status -" is "All".
In the "Type" and "Access" you don't have "All" - so same logic .
"All" is only used in the other views because of trashed item IIRC.
@andrepereiradasilva
You are right, but, in terms of UI, I think it is better to leave it.
well, we disagree :)
I think it should be removed, makes no sense since the other filter options don't have it.
You are right. It is only useful when Archived and Trashed are used.
Modifying PR now.
I have tested this item 
successfully on e579936
I like "All" because I ""hate"" these hiding search tools ;-)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9103.
2 against , 1 for. Hmm
@bertmert i understand what you mean
But that's a different matter, what you are saying is that search filter button pressed/not pressed state should be preserved on navigation across Joomla admin panel. That is another thing for other PR.
I don't think we should make "All" just to show the filter open, makes no sense to me.
This PR has received new commits.
CC: @bertmert, @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9103.
Please test again. 
I have tested this item successfully on 3180e4b
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9103.
I have tested this item successfully on 3180e4b
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9103.
I understand you now ;)
On 11 February 2016 at 10:09, andrepereiradasilva notifications@github.com
wrote:
I have tested this item [image:
3180e4b3180e4b
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/9103
https://issues.joomla.org/tracker/joomla-cms/9103.—
Reply to this email directly or view it on GitHub
#9103 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I have tested this item successfully on 3180e4b
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9103.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-13 17:45:57 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
| Labels |
Removed:
?
|
||
I have tested this item
successfully on e579936
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9103.