[#910] - Correct usage behavior.modal with custom selector
- Closed
- 27 Jul 2014
- Medium
- Build: master
- # 910
- Diff
- piotrmocko:patch-2
- Error default This pull request is targeted at the master branch. Pull requests should no longer be merged to master. Details
User tests: Successful: Unsuccessful:
When you use in Joomla
JHTML::('behavior.modal');
and
JHTML::('behavior.modal', 'a.test', array('parse' => false, 'fullScreen'=> true));
it would initialize SqueezeBox twice
and it would also create twice HTML tags: div#sbox-overlay and div#sbox-window
Here is one of many cases when it would not work correct.
When you try to run JavaScript
SqueezeBox.open($('element'), {
onOpen: function(){
$('element_container').inject( $('sbox-content') );
}
});
then it would insert HTML to first copy of SqueezeBox
but second copy of SqueezeBox would be opened with empty content.
SqueezeBox is not a class but a single instance of object which use static IDs.
This correction will prevent from loading HTML code twice.
Thanks Piotr! :)
Closed as per the comment on the tracker
Thanks for coding this, Piotr!
While we’re transitioning to a new integrated tracker, could you report the issue on our current main tracker at JoomlaCode and cross-reference each with a link to other?
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103
Alternatively, let me know if you’d like me to create it for you and I can go ahead and do that.
Thanks in advance and thanks again for coding this, Piotr!