Pending

User tests: Successful: Unsuccessful:

avatar elinw
elinw
28 Mar 2013

...te code.

avatar elinw elinw - open - 28 Mar 2013
avatar Lemings
Lemings - comment - 28 Mar 2013

Sorry for double comment, but related to @mbabker comment.
There is no use for Jaccess::getActions calls in tags, conatact, newsfeeds helpers.

One more thing in ContentHelper
$actions = array(
'core.admin', 'core.manage', 'core.create', 'core.edit', 'core.edit.own', 'core.edit.state', 'core.delete'
);

    foreach ($actions as $action)
    {
        $result->set($action, $user->authorise($action, $assetName));
    }

Predefined actions are used would not it be bettert to call Jaccess::getActionsFromFile here (Jaccess::getActions)?

I can prepare that if One wishes!

avatar elinw
elinw - comment - 28 Mar 2013

There are actions in the configuration of tags and we may well end up
making tags assets though at this point they are not.
But yes yes yes on the rest!
Elin

On Thu, Mar 28, 2013 at 12:00 PM, Lemings notifications@github.com wrote:

Sorry for double comment, but related to @mbabkerhttps://github.com/mbabkercomment.
There is no use for Jaccess::getActions calls in tags, conatact, newsfeeds
helpers.

One more thing in ContentHelper
$actions = array(
'core.admin', 'core.manage', 'core.create', 'core.edit', 'core.edit.own',
'core.edit.state', 'core.delete'
);

foreach ($actions as $action)
{
    $result->set($action, $user->authorise($action, $assetName));
}

Predefined actions are used would not it be bettert to call
Jaccess::getActionsFromFile here (Jaccess::getActions)?

I can prepare that I One wishes!


Reply to this email directly or view it on GitHub#911 (comment)
.

avatar elinw
elinw - comment - 28 Mar 2013

Close in preference to Edgars' version #912

avatar elinw elinw - close - 28 Mar 2013
avatar elinw elinw - head_ref_deleted - 28 Mar 2013

Add a Comment

Login with GitHub to post a comment