Pending

User tests: Successful: Unsuccessful:

avatar Paladin
Paladin
27 Mar 2013

For some reason, the attributes array was passed in but not used. It is now. At least for legacy users.

avatar Paladin Paladin - open - 27 Mar 2013
avatar nicksavov
nicksavov - comment - 28 Mar 2013

Thanks for coding this, Arlen!

While we’re transitioning to a new integrated tracker, could you report the issue on our current main tracker at JoomlaCode and cross-reference each with a link to other? Here’s the process for reporting on the other tracker:
http://docs.joomla.org/Filing_bugs_and_issues

Alternatively, let me know if you’d like me to create it for you and I can go ahead and do that.

Thanks in advance and thanks again for coding this, Arlen!

avatar elinw
elinw - comment - 28 Mar 2013

Arlen did you see my "make icons more generic" pr? Maybe we could join forces? #635

avatar Paladin
Paladin - comment - 30 Mar 2013

Generic icon code should solve this issue, as the root cause is the print-screen icon is treated differently from other icons. So if there's generic code used for every icon, it'd by definition render this PR redundant, unless it's applied only to the 3.x branch. This change would fit easily into the 2.5.x branch and leave the field clear for genericizing the code in the later branches, so I'll close this one, reissue it as a 2.5.x PR and go take a deeper look at the other PR.

avatar Paladin Paladin - close - 30 Mar 2013

Add a Comment

Login with GitHub to post a comment