Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8843] - Retrieving session expiration in wrong unit

?
avatar renekorss
renekorss
5 Jan 2016

Docs and therefore source code too claims that JSession::getExpire returns expiration in minutes. But it is initialised as seconds. See here and here.

If session lifetime is set to 30 minutes in backend, it returns 1800.

Also, it is used to set session.gc_maxlifetime in here, which takes seconds.

So it works well, just description is misleading.

avatar renekorss renekorss - open - 5 Jan 2016
avatar Bakual
Bakual - comment - 5 Jan 2016

Do you want to do a PR to change the description?

avatar renekorss
renekorss - comment - 5 Jan 2016

Yes, no problem.

avatar renekorss renekorss - reference | 6bc0c59 - 5 Jan 16
avatar Bakual
Bakual - comment - 5 Jan 2016

Thanks. Closing this issue since we have a PR.

avatar Bakual Bakual - change - 5 Jan 2016
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-01-05 13:18:34
Closed_By ⇒ Bakual
avatar Bakual Bakual - close - 5 Jan 2016
avatar Bakual Bakual - close - 5 Jan 2016
avatar brianteeman brianteeman - close - 5 Jan 2016
avatar Bakual
Bakual - comment - 5 Jan 2016

Also copied description of the issue to the PR.

avatar brianteeman brianteeman - change - 8 Mar 2016
Labels Added: ?

Add a Comment

Login with GitHub to post a comment