[#8842] - Search Tools (from JLayouts) implemented in com_menu (menus view)
- Closed
- 17 Jan 2016
- Medium
- Build: staging
- # 8842
- Diff
- andrepereiradasilva:jlayouts-com_menu-view-menus
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Description
In move to normalize the search/filter/order/limit bar (aka searchtools) in all administrator list views, and as other PR's have made for other list component/views, this PR adds JLayouts searchtools to com_menu menus view and replacing the old HTML code.
With that it also adds an option for ordering to com_menu menus view.
A PHP notice in hathor was corrected too.
Isis template
Before patch
After patch
Hathor template
Before patch
After patch
How to test
- Go to com_menu menus view (the one with the menutypes, not menu items view).
- Create some menus (at least one of them without linked modules)
- Apply the patch
- Test the Search Tools (Search field, ordering and limit).
- View hathor template to and check the php notice is not there now.
Observations
First time using a part of JLayouts so suggestions and code revisions are welcome.
Tags
administrator, menus, search tools, jlayouts, list views, normalization
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Ups. i will check when i have time, sorry for that. I will also put some screenshots them.
The goal here is to normalize the use of JLayouts searchtools in com_menus (menus view doesn't use it, the other views already use it).
@infograf768 code and test instructions updated.
Screenshots added.
Can you check now?
| Title |
|
||||||
I have tested this item 
successfully on 98f49de
Works now.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8842.
| Title |
|
||||||
I have tested this item successfully on 98f49de
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8842.
| Status | Pending | ⇒ | Ready to Commit |
RTC - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8842.
| Labels |
Added:
?
|
||
@infograf768 @NLRoosj thanks for testing.
rdeutz
- | Milestone |
Added: |
||
wilsonge
- | Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-17 00:49:17 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
This does not look like working. What do you expect exactly. Please attach a screenshot.
Here, except for the Clear Button in the menus list, I lose the correct search in the menu items list where the Menutype field disapears.