Feeling Lucky
?
[#8844] - Fix unit for session expiration
- Fixed in Code Base
- 8 May 2016
- Medium
- Build: staging
- # 8844
- Diff
- renekorss:staging
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
fixes #8843
Docs and therefore source code too claims that JSession::getExpire returns expiration in minutes. But it is initialised as seconds. See here and here.
If session lifetime is set to 30 minutes in backend, it returns 1800.
Also, it is used to set session.gc_maxlifetime in here, which takes seconds.
So it works well, just description is misleading.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Libraries |
andrepereiradasilva
- comment
- 2 Mar 2016
Every PR needs two successfully tests to be merged.
Clear test instructions for testers help a lot.
uglyeoin
- comment
- 3 Mar 2016
Remember when writing instructions that we are not all technical, but some of us like to test things, step by step idiot proof instructions is best.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8844.
| Category | Libraries | ⇒ | Documentation Libraries |
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-08 14:34:09 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 8 May 2016
Merged on review
What should happen to get this merged?