? Error

User tests: Successful: Unsuccessful:

avatar joo7
joo7
4 Dec 2015

correct code

avatar joo7 joo7 - open - 4 Dec 2015
avatar joo7 joo7 - change - 4 Dec 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Dec 2015
Labels Added: ?
avatar Bakual
Bakual - comment - 4 Dec 2015

Is there a way to test this change?

avatar brianteeman
brianteeman - comment - 4 Dec 2015

Yes. Run it through a CSS validator.
The original code is invalid and doesn't do anything.

avatar joo7
joo7 - comment - 4 Dec 2015

is it possible in github to see who wrote the code in the first place and for what reason?

avatar sovainfo
sovainfo - comment - 4 Dec 2015

@joo7 When viewing the file on github you can use blame and history to find out who wrote the code.
Normally that leads to a commit or PR that sorts of describes the reason.

avatar Bakual
Bakual - comment - 4 Dec 2015

Yes. Run it through a CSS validator.
The original code is invalid and doesn't do anything.

@brianteeman I'm aware of that. But since it is currently invalid it could be removed without changing anything.
However this PR changes behavior and thus I asked for test instructions. overflow: hidden may or may not be the desired behavior after all.

avatar Bakual
Bakual - comment - 4 Dec 2015

@joo7 It was introduced with #3169

avatar joo7 joo7 - reference | 557a18f - 5 Dec 15
avatar joo7
joo7 - comment - 5 Dec 2015

close in favor of #8595

avatar joo7 joo7 - change - 5 Dec 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-12-05 07:58:09
Closed_By joo7
avatar joo7 joo7 - close - 5 Dec 2015
avatar joo7 joo7 - close - 5 Dec 2015
avatar JoomliC
JoomliC - comment - 5 Dec 2015

@Bakual Yes, it was mine error ;-)
This could be removed with no issue.

Add a Comment

Login with GitHub to post a comment