User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
i realize that this overflow error was... mine! (2 years ago...)
So i can confirm this one could be removed!
About the @moz-document, i would say that you can remove this declaration too.
Added here 85b3ebc by @infograf768 (if Jean-Marie, could you confirm that this declaration is not needed anymore ?)
As @moz-document is still experimental (https://developer.mozilla.org/en/docs/Web/CSS/@document), i don't see a reason to use it today, as in recent version fo Firefox, i can't reproduce the issue for which it was intended for "[#29014] *Firefox 14.0.1: Insert Image, Article or Pagebreak always inserts on top".
Hi @joo7 ,
I've seen you have opened a new PR for moz-document : #8601
Do you know you can update your PR here just by editing the file modas.css again in your branch, or directly here ?
As the purpose of your PRs is the same : clean mootools modal from css errors.
When using the component Patch Tester for Joomla, you won't be able to apply and test the 2 patchs in the same time, as the changes in the same file (https://github.com/joomla-extensions/patchtester/releases).
So, would be easier for testers to have the 2 changes here in the same PR ;-)
For Testing (as mootools modals are removed from Joomla in 3.5.0) :
I have tested on iphone and mac (with #8601 and #8595 applied in manual), with third party extensions on 3.5.0-beta1 : all is ok
In the same time, i have tested this css lines removal on a 3.4.5, with previously used mootools modals for select user, image, etc... just to be sure. And it's working as well!
So, the 2 deletions seem ok for all usage of "deprecated" mootools modal.
Cyril
I have tested this item successfully on 557a18f
Status | Pending | ⇒ | Ready to Commit |
Setting RTC - thanks for testing
Labels |
Added:
?
|
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-06 16:27:54 |
Closed_By | ⇒ | rdeutz |
Labels |
Removed:
?
|
Milestone |
Removed: |
I have tested this item successfully on 557a18f
It's ok for me to remove this declaration.
Tested with "old" mootools modals, and this is correct to remove it (and B/C is ok as joomla is not using anymore mootools modals).
By default, overflow has the "visible" value.
"none" was not a valid value (and so visible was used).
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8595.