? Failure

User tests: Successful: Unsuccessful:

avatar joo7
joo7
5 Dec 2015

delete invalid code (in favor of #8594 )

avatar joo7 joo7 - open - 5 Dec 2015
avatar joo7 joo7 - change - 5 Dec 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Dec 2015
Labels Added: ?
avatar JoomliC JoomliC - test_item - 5 Dec 2015 - Tested successfully
avatar JoomliC
JoomliC - comment - 5 Dec 2015

I have tested this item :white_check_mark: successfully on 557a18f

It's ok for me to remove this declaration. :+1:
Tested with "old" mootools modals, and this is correct to remove it (and B/C is ok as joomla is not using anymore mootools modals).
By default, overflow has the "visible" value.
"none" was not a valid value (and so visible was used).


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8595.

avatar JoomliC JoomliC - test_item - 5 Dec 2015 - Tested successfully
avatar JoomliC
JoomliC - comment - 5 Dec 2015

i realize that this overflow error was... mine! (2 years ago...)
So i can confirm this one could be removed!

About the @moz-document, i would say that you can remove this declaration too.
Added here 85b3ebc by @infograf768 (if Jean-Marie, could you confirm that this declaration is not needed anymore ?)

As @moz-document is still experimental (https://developer.mozilla.org/en/docs/Web/CSS/@document), i don't see a reason to use it today, as in recent version fo Firefox, i can't reproduce the issue for which it was intended for "[#29014] *Firefox 14.0.1: Insert Image, Article or Pagebreak always inserts on top".
:+1:

avatar joo7 joo7 - reference | 700a98d - 6 Dec 15
avatar JoomliC
JoomliC - comment - 7 Dec 2015

Hi @joo7 ,

I've seen you have opened a new PR for moz-document : #8601
Do you know you can update your PR here just by editing the file modas.css again in your branch, or directly here ?
As the purpose of your PRs is the same : clean mootools modal from css errors.

When using the component Patch Tester for Joomla, you won't be able to apply and test the 2 patchs in the same time, as the changes in the same file (https://github.com/joomla-extensions/patchtester/releases).
So, would be easier for testers to have the 2 changes here in the same PR ;-)

For Testing (as mootools modals are removed from Joomla in 3.5.0) :

  • Apply the patch and test modals used in third party extensions (everywhere you have a mootools modal)
  • Test if behavior is ok on all devices (mobile, browser...)

I have tested on iphone and mac (with #8601 and #8595 applied in manual), with third party extensions on 3.5.0-beta1 : all is ok
In the same time, i have tested this css lines removal on a 3.4.5, with previously used mootools modals for select user, image, etc... just to be sure. And it's working as well!
So, the 2 deletions seem ok for all usage of "deprecated" mootools modal. :+1:

Cyril

avatar NLRoosj NLRoosj - test_item - 13 Dec 2015 - Tested successfully
avatar NLRoosj
NLRoosj - comment - 13 Dec 2015

I have tested this item :white_check_mark: successfully on 557a18f


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8595.

avatar brianteeman brianteeman - change - 14 Dec 2015
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 14 Dec 2015

Setting RTC - thanks for testing


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8595.

avatar joomla-cms-bot joomla-cms-bot - change - 14 Dec 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 6 Jan 2016
Milestone Added:
avatar rdeutz rdeutz - reference | 9fe987a - 6 Jan 16
avatar rdeutz rdeutz - close - 6 Jan 2016
avatar rdeutz
rdeutz - comment - 6 Jan 2016

closing this one because it fails on travis and it was easier to redo the patch as to look what is wrong here, redo PR #8850

avatar rdeutz rdeutz - change - 6 Jan 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-01-06 16:27:54
Closed_By rdeutz
avatar rdeutz rdeutz - close - 6 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - close - 6 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jan 2016
Labels Removed: ?
avatar wilsonge wilsonge - change - 22 Mar 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment