Install and activate the Joomla! breadcrumbs module. Visit a page. Here is a demo website with it installed.
http://eoindemo.demojoomla.com/index.php/bread-crumbs-content
Breadcrumbs with the class "active" on the active breadcrumb (page).
Active Breadcrumb is active, but text saying "you are here" is also active. The first li does not need the class active on it (this is hard coded and never changes to inactive). It's easy to undo with a HTML override, but it should be part of the core, it requires minimal testing and the change took me 20 seconds.
Here is a picture to better explain it.
If I could upload a .zip file I would provide this fix for you, since I can't you can locate the issue here.
mod_breadcrumbs/tmpl/default.php
line 17
change li class="active" to li (remove the class)
Thanks Bertmert. Thinking about it, this change may require a change to the standard Joomla! template too. I will test that and do two pull requests if need be.
I agree on the issue. But indeed this would require an override for Protostar and may change some templates display which do not use an override. Enough to qualify as not B/C, that is the question.
I don't know @infograf768 I'm kind of a noob to this stuff. @wilsonge can you provide information as to whether this is considered breaking b/c? It is more likely to be templates that suffer than extensions (although not completely impossible). I would be happy to submit a pull request for the core as well as any template changes for Protostar. Is it possible to submit both?
I think it's fine to do. I'd just push it into 3.5 to be safe.
Yes
Ok I'll try to understand a pull request and submit one today
ty!
@uglyeoin https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests - ping me If you need help
PR in itself looks fine to me (haven't checked it actually works)
@infograf768 can you explain why you prefer an override to a less/css change? I don't mind either way it's about the same amount of work and so long as it all works at the end I am happy. I would however, prefer to do things the right way and learn for the future, anything you can do to assist is greatly appreciated.
The way I see it the override uses more files, larger files and therefore, makes the Joomla! core larger, I think adding a few characters to a less/css file is an improvement on this. Granted it is not a huge overhead but if everyone has the same attitude Joomla! will remain as light as possible.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-06 11:10:23 |
Closed_By | ⇒ | brianteeman |
Closed as issue was resolved with PR
Try a pull request! So, anybody is able to test your code changes.
Here's a description:
https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests