[#8543] - Some missing jquery framework dependency
- Closed
- 16 Jan 2016
- Medium
- Build: staging
- Easy Test
- # 8543
- Diff
- andrepereiradasilva:missing-js-frameworks
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Description
This PR adds some missing jquery framework dependency.
How to test
- In admin go to Content -> Media and check there is no javascript errors in the js console.
- In admin go to System -> Global Check in and check there is no javascript errors in the js console.
You can also check the code to see jquery js are loaded.
B/C
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | JavaScript |
| Easy | No | ⇒ | Yes |
Yes it's loaded, but because JDocument renders the scripts in this order:
- External scripts
- Inline scripts
If they were loaded in the order they are called (not matter if they are internal or external) there would be a JS error because jQuery was not loaded yet.
They work now, because some other component in that pages is calling jQuery, and since jQuery is an external js it's always loaded before the inline scripts.
This is only for js integrity no changes in output.
I have tested this item 
successfully on 5bf71d1
Ok agree than my test was successfull.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8543.
I have tested this item successfully on 5bf71d1
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8543.
thanks @zero-24 @anibalsanchez
can we have an RTC :)
| Status | Pending | ⇒ | Ready to Commit |
@joomla-bot RTC this
| Labels |
Added:
?
|
||
rdeutz
- | Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-16 23:20:48 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
Hi @andrepereiradasilva can you contact me please. Glip/email so we can clean up your staging branch. I'm having to squash you're commits every time which is time consuming. Would save my time (and probably some of yours if i can help you fix up your branch).
either email me at george.wilson@community.joomla.org grab me on glip or skype george.wilson1992
Don't worry about it! I know I've made this mistake several times :)
hmm jquery is loaded also without this patch or i miss something?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8543.