? Success
Pull Request for # 8321
Referenced as Related to: # 8321

User tests: Successful: Unsuccessful:

avatar roland-d
roland-d
8 Nov 2015

Problem

Changing permissions won't take effect and only the old settings remain.

How to test

  1. Go to System -> Global Configuration
  2. Click on the Server Tab
  3. Make sure Database Type is set to MySQLi
  4. Click on the Permission tab
  5. Change permissions and see that Joomla says they are stored
  6. Reload page, permissions have old value again
  7. Apply patch
  8. Change permissions and see that Joomla says they are stored
  9. Reload page, permissions now have the new value

This works for the global permissions and for the component permissions.
If you are using the PDO driver, there is another fix for that at #8322

Do note, these patches cannot be used together as they change the same file.

avatar roland-d roland-d - open - 8 Nov 2015
avatar roland-d roland-d - change - 8 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2015
Labels Added: ?
avatar roland-d roland-d - change - 8 Nov 2015
Rel_Number 0 8321
Relation Type Pull Request for
avatar dgt41 dgt41 - test_item - 8 Nov 2015 - Tested successfully
avatar dgt41
dgt41 - comment - 8 Nov 2015

I have tested this item :white_check_mark: successfully on c569899


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8343.

avatar wilsonge wilsonge - test_item - 8 Nov 2015 - Tested successfully
avatar wilsonge
wilsonge - comment - 8 Nov 2015

I have tested this item :white_check_mark: successfully on c569899

Tested with MySQLi and MySQL PDO (when combined with the mentioned #8322) and both worked successfully with the patch applied.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8343.

avatar wilsonge wilsonge - change - 8 Nov 2015
Status Pending Ready to Commit
avatar wilsonge wilsonge - change - 8 Nov 2015
Labels Added: ?
avatar Fedik Fedik - test_item - 8 Nov 2015 - Tested successfully
avatar Fedik
Fedik - comment - 8 Nov 2015

I have tested this item :white_check_mark: successfully on c569899


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8343.

avatar wilsonge wilsonge - change - 8 Nov 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-11-08 17:54:42
Closed_By wilsonge
avatar wilsonge wilsonge - close - 8 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - close - 8 Nov 2015
avatar wilsonge wilsonge - reference | 5e1e515 - 8 Nov 15
avatar wilsonge wilsonge - merge - 8 Nov 2015
avatar wilsonge wilsonge - close - 8 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2015
Labels Removed: ?
avatar wilsonge
wilsonge - comment - 8 Nov 2015

Merged as we have 3 good tests - thanks guys :)

avatar Fedik
Fedik - comment - 8 Nov 2015

ah, hold on! you are too fast hahah :smile:
The Modules permission still does not save anything ...
Sorry!

avatar roland-d
roland-d - comment - 8 Nov 2015

@Fedik Thanks for that feedback. I will create a separate PR for that, completely did not think of module permissions :)

avatar roland-d roland-d - head_ref_deleted - 8 Nov 2015
avatar roland-d
roland-d - comment - 8 Nov 2015

@Fedik I can't reproduce the issue with modules. Anything specific to do?

avatar Fedik
Fedik - comment - 8 Nov 2015

hm, no, nothing specific, just change and refresh the page ..
I checked with MySQLi and on Global Configuration, Article Permission, Category Permission all works ... but on Module permissions nothing saved
strange ..

avatar Fedik
Fedik - comment - 8 Nov 2015

ah I think the Asset Tree in Module permissions was broken by previous test.
I have tested again on clear "test database" ... all fine. :smiley:
Sorry for disturb!

avatar roland-d
roland-d - comment - 8 Nov 2015

@Fedik, perfect :+1:

avatar zero-24 zero-24 - change - 8 Nov 2015
Milestone Added:

Add a Comment

Login with GitHub to post a comment