?
Related to # 8343
Referenced as Pull Request for: # 8343
avatar Fedik
Fedik
7 Nov 2015

I tried test the beta, and noticed that permission editing does not really work, or works randomly.
After changing any permission dropdown I got undefined error.

Global configuration:
After any change I got undefined error and X icon
screen 2015-11-07 15 36 14 1241x383

Module editing:
Sometimes it works, sometimes it is not.
screen 2015-11-07 15 37 09 836x433

avatar Fedik Fedik - open - 7 Nov 2015
avatar Fedik
Fedik - comment - 7 Nov 2015

it is after #8132
@tflm84 can you please check?

avatar zero-24
zero-24 - comment - 7 Nov 2015

Hmm i have no Problem. Can You make sure You have cleaned The browser cache?

avatar Fedik
Fedik - comment - 7 Nov 2015

yes, and I made clear installation for J3.5Beta1
strange

avatar Fedik
Fedik - comment - 7 Nov 2015

ok,
database driver MySQL PDO => nothing works
MySQLi => show that works, at least no errors, but the changes not saved

avatar zero-24
zero-24 - comment - 7 Nov 2015

Oh yes that looks bad. I Can confirm it with pdo driver

avatar Fedik
Fedik - comment - 7 Nov 2015

server answer does not looks as correct

{
"success":true,
"message":null,
"messages":null,
"data":"{\"queryString\":\"UPDATE `xxx_assets`\\nSET rules = '{\\\\\\\"core.login.site\\\\\\\":{\\\\\\\"1\\\\\\\":1,\\\\\\\"12\\\\\\\":1},\\\\\\\"core.login.offline\\\\\\\":{\\\\\\\"1\\\\\\\":1,\\\\\\\"12\\\\\\\":1},\\\\\\\"core.create\\\\\\\":{\\\\\\\"12\\\\\\\":1},\\\\\\\"core.login.admin\\\\\\\":{\\\\\\\"12\\\\\\\":0},\\\\\\\"core.admin\\\\\\\":{\\\\\\\"12\\\\\\\":1}}'\\nWHERE `name` = 'com_config'\"}"
}
avatar Fedik
Fedik - comment - 7 Nov 2015

the thing in $result = $this->db->execute(); return $result;
for PDO the $result is some PDO object not a boolean

avatar zero-24
zero-24 - comment - 7 Nov 2015

I have a fix. Give ne a second to send zhe PR ;)

avatar zero-24
zero-24 - comment - 7 Nov 2015

Can you test #8322 @Fedik

avatar zero-24 zero-24 - change - 7 Nov 2015
Labels Added: ?
avatar Fedik
Fedik - comment - 7 Nov 2015

@zero-24 after #8322 the error disappeared :wink:

but it still save nothing, after refresh the page I get old permissions.

try in Global configuration:

  • Open the "Author" user group
  • Set "Edit State" to "Allow" - you get "success" icon
  • Push F5 to refresh the page
  • Again, open the "Author" user group

For "Edit State" I get old "inherit" instead of "allow" after refresh the page.

avatar zero-24
zero-24 - comment - 7 Nov 2015

it is the same behavior as on mysql ;) You need to hit the save button. The ajax efects just show how it will look like after the save.

avatar Fedik
Fedik - comment - 7 Nov 2015

hm, nothing sorry .. still nothing saved
strange

but as I see ConfigModelApplication::storePermissions() should do some saving,
now I confused :wink:

avatar zero-24
zero-24 - comment - 7 Nov 2015

Yes. I Can confirm nothing gets saved also not on hit the save button. :(

avatar Fedik
Fedik - comment - 7 Nov 2015

form #8132 description:

Now, the permissions will be stored immediately after changing a value via AJAX. This solution leads to smaller forms and consistent storage of the permissions.

avatar brianteeman
brianteeman - comment - 7 Nov 2015

If that's true then the description us wrong
On 7 Nov 2015 3:57 pm, "zero-24" notifications@github.com wrote:

it is the same behavior as on mysql ;) You need to hit the save button.
The ajax efects just show how it will look like after the save.


Reply to this email directly or view it on GitHub
#8321 (comment).

avatar zero-24
zero-24 - comment - 7 Nov 2015

correct @brianteeman you can blame me i have missunderstand it (btw also save don't work) @Fedik is correct that it is broken

@dgt41 and I is working on a fix. Thanks

avatar roland-d
roland-d - comment - 8 Nov 2015

Permission saving is fixed in #8343 this does not include the PDO fix.

avatar roland-d roland-d - change - 8 Nov 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-11-08 17:32:16
Closed_By roland-d
Rel_Number 0 8343
Relation Type Related to
avatar roland-d roland-d - close - 8 Nov 2015
avatar roland-d roland-d - close - 8 Nov 2015
avatar roland-d
roland-d - comment - 8 Nov 2015

Closing this as we have a PR at #8343


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8321.

Add a Comment

Login with GitHub to post a comment