? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
7 Nov 2015

What is changed

Not allways we get a boolean if a SQL is true. e.g. on PDO we get a PDO object.

How to test

  • install beta 1 (PDO Database Driver)
  • go to the global config.
  • try to change the config
  • you got an "undefined" error
  • apply the patch
  • it works.
  • try it again with the mysql driver.

Fixes #8321 Thnaks @Fedik

avatar zero-24 zero-24 - open - 7 Nov 2015
avatar zero-24 zero-24 - change - 7 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Nov 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 7 Nov 2015
Milestone Added:
avatar Fedik
Fedik - comment - 7 Nov 2015

I can confirm, that this pull fixes part of #8321 issue :wink:

avatar zero-24 zero-24 - alter_testresult - 7 Nov 2015 - Fedik: Tested successfully
avatar wilsonge
wilsonge - comment - 8 Nov 2015

I've tested this and it works - but I'd much prefer the solution that I've commented in the code - which does the same thing in far less code :)

avatar Fedik Fedik - test_item - 8 Nov 2015 - Tested successfully
avatar Fedik
Fedik - comment - 8 Nov 2015

I have tested this item :white_check_mark: successfully on 8f311e9


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8322.

avatar joomla-cms-bot
joomla-cms-bot - comment - 8 Nov 2015

This PR has received new commits.

CC: @Fedik


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8322.

avatar zero-24
zero-24 - comment - 8 Nov 2015

Fixed @wilsonge

avatar wilsonge wilsonge - test_item - 8 Nov 2015 - Tested successfully
avatar wilsonge
wilsonge - comment - 8 Nov 2015

I have tested this item :white_check_mark: successfully on 93ff193

Works successfully with PDO and MySQLi drivers


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8322.

avatar Fedik Fedik - test_item - 9 Nov 2015 - Tested successfully
avatar Fedik
Fedik - comment - 9 Nov 2015

I have tested this item :white_check_mark: successfully on 93ff193


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8322.

avatar zero-24 zero-24 - change - 9 Nov 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 9 Nov 2015

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8322.

avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2015
Labels Added: ?
avatar wilsonge wilsonge - close - 9 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - close - 9 Nov 2015
avatar wilsonge wilsonge - reference | 97a8745 - 9 Nov 15
avatar wilsonge wilsonge - merge - 9 Nov 2015
avatar wilsonge wilsonge - close - 9 Nov 2015
avatar wilsonge wilsonge - change - 9 Nov 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-11-09 11:42:50
Closed_By wilsonge
avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2015
Labels Removed: ?
avatar zero-24 zero-24 - head_ref_deleted - 9 Nov 2015

Add a Comment

Login with GitHub to post a comment