[#8323] - Isis template: no preview for media field due to undefined variable
- Closed
- 17 Nov 2015
- Medium
- Build: staging
- Easy Test
- # 8323
- Diff
- mttronc:mttronc-patch-1
- Pending Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
If field media has attribute preview set to true, php complains about $showPreview not being declared and hence no preview is being shown.
Notice: Undefined variable: showPreview in /var/www/joomla/administrator/templates/isis/html/layouts/joomla/form/field/media.php on line 72
Looks like in the case switch in administrator/templates/isis/html/layouts/joomla/form/field/media.php there is a break that is not supposed to be there, since leaving $showPreview undefined in some cases.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Milestone |
Added: |
||
I have tested this item 
successfully on 58efabf
Works fine. Good work!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8323.
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Administration UI/UX |
I have not tested this item.
I could not reproduce the problem. Can anybody give a hint how to test this one.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8323.
You can modify modules/mod_custom/mod_custom.xml line 39 and add the attribute preview="true" to the media field.
If you now select a mod_cutom module in the Joomla administration and choose tab Options, PHP shows an undefined variable notice and there is no eye icon and no preview image in front of the media input form.
Thanks @mttronc Mmmhh. Before asking I did excatly what you described.
I use latest staging on Win7 with php 5.5.x on ampps, notices are definitely displayed and your patch is not applied. But I can not reproduced this behaviour. No notice and I can see the eye icon.
Ok. I will retry tomorrow on a linux server.
I have tested this item successfully on 58efabf
With everything cleaned up (browser cache, fresh installation) I didn´t get the notice but I could see the problem with the eye icon. Applying your patch solves this problem. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8323.
| Status | Pending | ⇒ | Ready to Commit |
RTC Thanks. This should go into 3.5.0 ;)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8323.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-17 16:18:10 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
Protostar override is a copy paste of this file, so I would like to ask for the same correction there. Thanks!